implode function returning an additional value

Question

so I have:

$input=array($fname,$lname);

I then use:

$valueString = join(",",$values);
    echo $valueString;

if I had input $fname = a and $lname = f I then receive:

a,fa,f

Not sure why I get the 'fa' value and how to edit my code so I get just a,f

apologies for the poor question, though it would be simpler

this is the function;

 function insert($coloumn, $values, $table)
{

    $valueString = join(",",$values);
    echo $valueString;
    $insert = "INSERT INTO $table ($coloumn)
        VALUES ($valueString)";
    //$query = $this->dbLocalhost->query($insert)
    //or die("could not insert:".mysql_error());

    if($this->dbLocalhost->query($insert))
    {
    header('Location: blah.php');
    }

}

and the this the page for the inputs:

   <?php
session_start();
require_once("database.php");
$db = new Database();
$table = "tables";
$coloumn = "firstname, lastname";
if(isset($_POST['Add']))
{

    $fname = $_POST['firstname'];
    $lname = $_POST['lastname'];



    $input=array($fname,$lname);

    $db->emptyCheck($coloumn, $input, $table);



}
?>
<html>
    <head>
        <title>Add new Record</title>
    </head>
    <body>
        <br><br><br><br><br>
        <div id ="formAlign" align="center">
        <form action="" method ="post">
            <label for="firstname"> First Name:</label>
            <input type ="text" name="firstname">
            <label for="lastname"> Last Name:</label>
            <input type="text" name="lastname">

            <input type="submit" name="Add">
        </form>
        </div>
    </body>
</html>

To clarify

$db->emptyCheck($coloumn, $input, $table);

leads to:

$this->insert($coloumn, $values, $table);

being called.

what is $values? Are you sure it's $valueString = join(",",$values);? or $valueString = join(",",$input); — Muthu Kumaran
– Muthu Kumaran, Commented Nov 15, 2012 at 13:07
I'm pretty sure you just get two a,f because you're outputting it twice. Please show a complete code sample that reproduces this problem. — deceze
– deceze ♦, Commented Nov 15, 2012 at 13:08
That's still not a complete code sample we could check. var_dump($values) right before you join them, var_dump any other values you're outputting (not echo) so you can actually distinguish between different output. If you still see the same problem, let us know. — deceze
– deceze ♦, Commented Nov 15, 2012 at 13:20

Jason McCreary · Accepted Answer · 2012-11-15 13:07:53Z

4

implode() works fine. You are outputting the result of implode() twice.

'a,f' . 'a,f' = 'a,fa,f'

Note: I encourage using the root function and not the alias. (e.g. implode() vs. join())

answered Nov 15, 2012 at 13:07

Jason McCreary

73.3k23 gold badges140 silver badges177 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

normower Over a year ago

Thanks, i noticed that the function was being called twice and I change join to implode.

Collectives™ on Stack Overflow

implode function returning an additional value

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related