ObjectOutput throws java.io.NotSerializableException

Question

This is the class that's about to be serialized into a byte array.

public class DummyClass implements Serializable
{
    private static transient final long serialVersionUID    = -8483859843874771619L;
    public String   y;

    public DummyClass(String y)
    {
        this.y = y;
    }
    public String getY()
    {
        return this.y;
    }
}

This is the Serialization execution test

    ByteArrayOutputStream bos = new ByteArrayOutputStream();
    ObjectOutput out = null;
    byte[] bs = null;
    try
    {
        DummyClass dummyClass = new DummyClass("World I Salute you");
        out = new ObjectOutputStream(bos);
        out.writeObject(dummyClass); // <--- Throws exception here
        bs = bos.toByteArray();
    }
    finally
    {
        out.close();
        bos.close();
    }

and regarding the stack trace:

java.io.NotSerializableException: tests.DummyClassTest
at java.io.ObjectOutputStream.writeObject0(Unknown Source)
at java.io.ObjectOutputStream.defaultWriteFields(Unknown Source)
at java.io.ObjectOutputStream.writeSerialData(Unknown Source)
at java.io.ObjectOutputStream.writeOrdinaryObject(Unknown Source)
at java.io.ObjectOutputStream.writeObject0(Unknown Source)
at java.io.ObjectOutputStream.writeObject(Unknown Source)
at tests.DummyClassTest.dummyTest(DummyClassTest.java:109)

The Obvious question is what am i doing wrong?

Cheers.

EDIT:

The whole Class

public class DummyClassTest
{
    public class DummyClass implements Serializable
    {
        private static transient final long serialVersionUID    = -8483859843874771619L;
        public String   y;

        public DummyClass(String y)
        {
            this.y = y;
        }
        public String getY()
        {
            return this.y;
        }
    }

    @Test
    public void dummyTest() throws IOException
    {
        ByteArrayOutputStream bos = new ByteArrayOutputStream();
        ObjectOutput out = null;
        byte[] bs = null;
        try
        {
            DummyClass dummyClass = new DummyClass("World I Salute you");
            out = new ObjectOutputStream(bos);
            out.writeObject(dummyClass);
            bs = bos.toByteArray();
        }
        finally
        {
            out.close();
            bos.close();
        }
    }
}

I don't think this is all the relevant code. Where is DummyClassTest defined? — Perception
– Perception, Commented Nov 16, 2012 at 7:52
You mean the DummyClassTest All this code is in that class. Is a JUnit test. — Evan P
– Evan P, Commented Nov 16, 2012 at 7:54
Is your DummyClass a separate class or defined within DummyClassTest? — DRCB
– DRCB, Commented Nov 16, 2012 at 7:54
You are trying to serialize a different class than DummyClass, which I supose is not serializable. — Ioan
– Ioan, Commented Nov 16, 2012 at 7:55

JB Nizet · Accepted Answer · 2012-11-16 07:57:24Z

8

A non-static inner class has an implicit reference to its outer class instance. So when you serialize DummyClass, you're also serializing this implicit reference to the DummyClassTest instance owning it.

Define the DummyClass as a top-level class (non nested), or as a static inner class, and everything will work as expected.

The following:

public class DummyClassTest {
    public class DummyClass {
    }
}

is more or less equivalent to

public class DummyClassTest {
}

public class DummyClass {
    private DummyClassTest outerInstance;
}

answered Nov 16, 2012 at 7:57

JB Nizet

694k94 gold badges1.3k silver badges1.3k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Evan P Over a year ago

That's the stupidest thing I've ever wrote. Thanks I forgot to test that. :)

Collectives™ on Stack Overflow

ObjectOutput throws java.io.NotSerializableException

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related