Javascript form validation submit errors

Question

From everything I've seen around the net, it appears that the following code should do the following (and this is my expectation):

If the email ("aid") does not match the regex, show alert message and return false
If the password ("pass") is blank, show alert message and return false
If both conditions pass validation submit the form

The Javascript is as follows:

function validate() {
var email = document.getElementById('aid').value;
var pass = document.getElementById('apw').value;        
var emailPattern = /^[a-zA-Z0-9._-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,4}$/;  
if (!emailPattern.test(email)) {
    alert("Not a valid email address");
    return false;
}
if (pass == null || pass == "") {
    alert("Password is blank");
    return false;   
}
return true;
}

The opening for tag is as follows:

<form action="choose.php" onsubmit="validate();" method="post">

The problem I'm having is that when the submit button is clicked, the alert message will pop up, but then choose.php is loaded in the browser. I want the script, if the error conditions are triggered, to remain on the page until both conditions are passed.

Side note, here's a better RegEx for ya: ex-parrot.com/~pdw/Mail-RFC822-Address.html — Madbreaks
– Madbreaks, Commented Nov 28, 2012 at 0:05
There are valid e–mail addresses that will fail the e–mail test. Better to just let users enter whatever they want and test it by sending an e–mail. Oh, and the function doesn't have to return true, any value other than false will let the form submit. — RobG
– RobG, Commented Nov 28, 2012 at 0:10
I'm aware of the shortcomings with the above RegEx (and using RegEx to validate email in general), but these aren't really concerns for this project. Thanks for the links/input though. — dropknow1edge
– dropknow1edge, Commented Nov 28, 2012 at 0:35

Reza S · Accepted Answer · 2012-11-28 00:03:49Z

5

You need to change your onSubmit to onSubmit="return validate();". This way when it returns false, the form doesn't get submitted. Right now it just calls the validate() function and continues on with submitting the form

answered Nov 28, 2012 at 0:03

Reza S

9,8045 gold badges58 silver badges91 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Javascript form validation submit errors

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related