Error While adding Exception Filter in MVC 3

Question

I am trying to create custom exceptions for my mvc 3(razor) application. But its not working properly.

Following is the code I've written for custom exception class.

using System;
using System.Web.Mvc;

namespace TestApp.Helpers
{
    public class CustomExceptionAttribute : FilterAttribute, IExceptionFilter
    {
        public void OnException(ExceptionContext filterContext)
        {
            if (!filterContext.ExceptionHandled && filterContext.Exception is Exception)
            {
                //filterContext.Result = new RedirectResult("/shared/Error.html");
                filterContext.Result = new ViewResult { ViewName = "Error" };
                filterContext.ExceptionHandled = true;
            }
        }
    }
}

Below is the code in controller:

using System;
using System.Collections.Generic;
using System.Data;
using System.Data.Entity;
using System.Linq;
using System.Web;
using System.Web.Mvc;
using System.Text;
using TestApp.Domain;
using TestApp.Helpers;

namespace TestApp.Controllers
{
    [CustomException]
    public class MyController : Controller
    {
        private TestAppEntities db = new TestAppEntities();

        public ActionResult Create(int id)
        {
           // Throwing exception intentionally
           int a = 1;
           int b = 0;
           int c = a / b;
           //This is another method which is working fine.
           return View(CreateData(id, null));
        }
    }
}

And below is the code in 'Error.cshtml'

@model System.Web.Mvc.HandleErrorInfo
@{
    ViewBag.Title = "Error";
}
<h2>
    Sorry, an error occurred while processing your request.
</h2>
<div>
    <p>
        There was a <b>@Model.Exception.GetType().Name</b> while rendering <b>@Model.ControllerName</b>'s
        <b>@Model.ActionName</b> action.
    </p>
    <p>
        The exception message is: <b><@Model.Exception.Message></b>
    </p>
    <p>Stack trace:</p>
    <pre>@Model.Exception.StackTrace</pre>
</div>

When we run the application it throws the error at @Model.Exception.GetType().Name, because model is null. This is the exact error: NullReferenceException: Object reference not set to an instance of an object.

Can anybody please let me know what can be the exact reason for the error? How can I fix this?

Why you need a custom exception filter? Your custom implementation does exactly the same-thing the built-in (HandleErrorFilter) does. You are getting the exception bcoz you are not passing the handle error info instance. — VJAI
– VJAI, Commented Nov 28, 2012 at 14:10
Mark, Can you please tell me the exact point where I'm missing 'HandleErrorInfo' instance? Also I tried using built-in attribute, in following way: [HandleError(ExceptionType = typeof(Exception), View="Error")] this was not redirecting to error page instead it displayed the 'yellow screen of death' — Vivek Sharma
– Vivek Sharma, Commented Nov 28, 2012 at 14:35
see my answer. why u are specifying ExceptionType? it's not required right? — VJAI
– VJAI, Commented Nov 28, 2012 at 14:37

VJAI · Accepted Answer · 2012-11-28 14:37:17Z

1

You have to pass the HandleErrorInfo instance to the view.

string controllerName = (string)filterContext.RouteData.Values["controller"];
string actionName = (string)filterContext.RouteData.Values["action"];

HandleErrorInfo model = new HandleErrorInfo(filterContext.Exception, controllerName, actionName);
filterContext.Result = new ViewResult
{
   ViewName = "Error",   
   ViewData = new ViewDataDictionary<HandleErrorInfo>(model)
};

answered Nov 28, 2012 at 14:37

VJAI

32.9k23 gold badges108 silver badges166 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Error While adding Exception Filter in MVC 3

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related