PHP function to find certain values in an array, then execute code

Question

So I am trying to check to see if this array has an underscore in it. I am not sure if I am using the correct function to do this. Any input would be appreciated.

Some more info, if the array does have an underscore I want it to run the code below. This code seperates and gives me the attributes that I want. I also check if it has and S and then run some code. These are all output to queries which are then queried at the end.

    if (count($h)==3){
           if (strpos($h[2], '_') !== false)  // test to see if this is a weird quiestion ID with an underscore
               {
                    if (strpos($h[2], 'S') !== false)
                    {
                     // it has an S
                     $underscoreLocation = strpos($h[2], '_');
                     $parent = substr($h[2], 0, $underscoreLocation - 6); // start at beginning and go to S
                     $title = substr($h[2], $underscoreLocation - 5, 5);
                     $questions = "select question from lime_questions where sid =".$h[0]." and gid =".$h[1]." and parent_qid =".$parent." and title =".$title.";";
                    }
                    else
                    {
                     // there is no S
                     $underscoreLocation = strpos($h[2], '_');
                     $parent = substr($h[2], 0, $underscoreLocation - 2);
                     $title = substr($h[2], $underscoreLocation - 1, 1);
                     $questions = "select question from lime_questions where sid =".$h[0]." and gid =".$h[1]." and parent_qid =".$parent." and title =".$title.";";
                    }    
               }

           else
           {
            $questions = "select question from lime_questions where sid =".$h[0]." and gid =".$h[1]." and qid =".$h[2].";";
           }

Please, don't use mysql_* functions in new code. They are no longer maintained and the deprecation process has begun on it. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. If you choose PDO, here is a good tutorial. — Madara's Ghost
– Madara's Ghost, Commented Nov 28, 2012 at 21:15
@mackermann I recommend you to mention the problems with the code you are experiecning — soft genic
– soft genic, Commented Nov 28, 2012 at 21:25
I posted a new comment on my answer - let me know if it solves the problem. — user1694691
– user1694691, Commented Nov 28, 2012 at 23:00
I've modified my answer with a suggestion on how to proceeed. — user1694691
– user1694691, Commented Nov 28, 2012 at 23:14
I've updated again, run the script with the change and tell me what it outputs. — user1694691
– user1694691, Commented Nov 29, 2012 at 0:49

score 1 · Accepted Answer · 2012-11-29 01:10:32Z

1

strpos() is a good function to use when checking to see if a substring exists within a string, so your basic premiss is fine.

The haystack you're submitting to the strpos() (i.e. $h[2]) is a string , isn't it? You say in your question that you're checking if an array contains an underscore, but the code only checks to see if a single array item contains an underscore - these are two very different things.

If $h[2] is a sub array instead of just a string within the $h array then you need to iterate through the subarray and check each item.

so:

  for ($x=0; $x<count($h[2]); $x++) {
     if (strpos($h[2][$x], "_")!==false) {
         if (strpos($h[2][$x], 'S') !== false) {
            // Run code
         } else { 
            // Run code
         }
     }
  }

If $h[2] is just a string then what you have should be fine.

Update: try adding

print($h[2][$x].' - '.strpos($h[2][$x], ''));

on the line before

print ($h[2][$x].' - '.strpos($h[2][$x], ''));

This should give us an idea of what the problem is.

Update:

Based n the code we just ran things are very different from what I thought. First of all, not all of the $h arrays returned have 3 items. Secondly $h2 is a stirng, not a subarray.

so here's the new code:

  if (count($h)==3) {
     print($h2.' | ');
     if (strpos($h[2], "_")!==false) {
         print(' underscore was found | ');
         if (strpos($h[2], 'S') !== false) {
            // Run code
         } else { 
            // Run code
         }
     }
  } else {
     // array does not represent a question
  }

Also, you need to change all of the $h[2][$x] back to just $h[2]. Tell me how it goes.

edited Nov 29, 2012 at 1:10

answered Nov 28, 2012 at 21:29

user1694691

Sign up to request clarification or add additional context in comments.

16 Comments

user1694691 Over a year ago

You already setup the iteration through the sub array so no. I'll modify my answer to incldue the check for S.

user1694691 Over a year ago

can you give a breakdown of the array $h[2]? It's hard to be specific without knowing what the array consists of.

user1694691 Over a year ago

I don't see why the underscore wouldn't be detected. If you modify your question to include the modified code you're using then I can check for you.

user1694691 Over a year ago

you need to change $h[2] to $h[2][$x] for all occurrences of $h[2] within the 'for' loop.

user1694691 Over a year ago

let's try some debuugging.On the line before "if (strpos($h[2][$x], '') !== false)" - add the following: print ($h[2][$x].' - '.strpos($h[2][$x], '')); then run the script and tell me what it prints.

|

Collectives™ on Stack Overflow

PHP function to find certain values in an array, then execute code

1 Answer 1

16 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

16 Comments

Your Answer

Sign up or log in

Post as a guest

Related