Codeigniter form validation callback function not working

Question

I've written a simple callback function which isn't working. My other callbacks (which are in the same library file) work fine so I guess the problem has to do with my code.

The parameter passed in the callback function takes the form of a chunk of PHP which is eval()'ed to form part of an 'if()' statement in the function itself.

Here's what's in the controller:

$this->form_validation->set_rules('rating', 'Rating','required');
$condition = $this->input->post('rating')  . " != 'Excellent'";
$this->form_validation->set_rules('details', 'Details', 'required_conditional[' . htmlentities($condition) .']');

And here's the callback function itself:

function required_conditional($str, $condition)
{
    if (eval(html_entity_decode($condition))) {
        if ($str == '') {
            $this->set_message('required_conditional', 'The %s field is required');
            return FALSE;
        }
        else {
            return TRUE;
        }
    }
}

Any ideas why it's not working anyone?

Thanks, Matt

mind to post some examples of $condition?

ax.
– ax.

2009-09-01 10:23:43 +00:00
Commented Sep 1, 2009 at 10:23 — ax.
– ax., Commented Sep 1, 2009 at 10:23
See the second line in the first code snippet.

user166508
– user166508

2009-09-01 10:49:29 +00:00
Commented Sep 1, 2009 at 10:49 — user166508
– user166508, Commented Sep 1, 2009 at 10:49

jimyi · Accepted Answer · 2009-09-01 23:44:29Z

2

It's because eval evaluates statements, not expressions. This will give you a parse error:

$test = "1 > 0";
if (eval($test)) { echo "echo!"; }

And this will work as you expect it to:

$test = "return 1 > 0;";
if (eval($test)) { echo "echo!"; }

answered Sep 1, 2009 at 23:44

jimyi

31.3k3 gold badges40 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user166508 Over a year ago

OK, so in the case of my example above, I should change $condition to: return $this->input->post('rating') . " != 'Excellent'"; ?? I'd actually created a simplified example there. What I really need to do is this: $condition = "('" . $this->input->post('exterior_condition_rating') . "' != '-1') && ('" . $this->input->post('exterior_condition_rating') . "' != '5 - Excellent')"; so how would I get that to work?

user166508 Over a year ago

Sorry, didn't realise the line breaks would be stripped out. Hope it's still readable!

jimyi Over a year ago

$condition = "return ('" . $this->input->post('exterior_condition_rating') . "' != '-1') && ('" . $this->input->post('exterior_condition_rating') . "' != '5 - Excellent');"

Neeraj Kumar · Accepted Answer · 2009-09-04 12:50:53Z

2

shouldn't you use "callback_<function name>" ?

answered Sep 4, 2009 at 12:50

Neeraj Kumar

7101 gold badge8 silver badges23 bronze badges

1 Comment

user166508 Over a year ago

I've extended the validation class and included the function in there so there's no need to use the callback_ prefix.

Timur Asaliev · Accepted Answer · 2009-09-08 09:46:22Z

2

Yep the correct syntax to call form validation callbacks it to use "callback_"

answered Sep 8, 2009 at 9:46

Timur Asaliev

743 bronze badges

Collectives™ on Stack Overflow

Codeigniter form validation callback function not working

3 Answers 3

3 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related