Firebug giving me a syntax error in OnClick function

Question

Here's my HTML:

 <input type='checkbox' name='PatientReady1' value='Yes' checked onClick="PatientReady ("PatientReady1","111","PatientReady")">

And my JavaScript:

function PatientReady(element, TriageNo, Field){
    debugger;
        if (element.checked == 1){
            new Ajax.Request (
                "PatientReady.asp",
                        {   
                        method: 'post',
                        parameters: {
                                    TriageNo: TriageNo,
                                    strReady: "Yes",
                                    strElement: Field
                                    },
                        asynchronous:false
                            }
                            
                        );
        }
        else{
            new Ajax.Request (
                "PatientReady.asp",
                        {   
                        method: 'post',
                        parameters: {
                                    TriageNo: TriageNo,
                                    strReady: "No",
                                    strElement: Field
                                    },
                        asynchronous:false
                            }
                            
                        );
        }
}

For some reason I'm getting a syntax error, when I click on the checkbox... I'm sure I'm missing some tiny stupid thing, perhaps a fresh set of eyes can help?

onclick="PatientReady ("PatientReady1","111","PatientReady")" - are those supposed to be single quotes in the function call? — Mark
– Mark, Commented Sep 1, 2009 at 18:52

James Black · Accepted Answer · 2009-09-01 18:54:26Z

1

As Mark mentioned, if you have double quotes around your string, inside the string should only be single-quotes. It doesn't matter which one you use, but try to be consistent, for readability purposes.

answered Sep 1, 2009 at 18:54

James Black

41.9k10 gold badges92 silver badges173 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Zed · Accepted Answer · 2009-09-01 18:53:04Z

1

Use apostrophe instead of quotation mark after onClick:

onClick="PatientReady('PatientReady1','111','PatientReady')"

Also checked should be:

checked="checked"

answered Sep 1, 2009 at 18:53

Zed

57.8k9 gold badges79 silver badges101 bronze badges

1 Comment

John Millikin Over a year ago

Just checked is fine and legal in HTML.

Jay · Accepted Answer · 2009-09-01 18:56:16Z

1

Try using this syntax:

<input type='checkbox' name='PatientReady1' value='Yes' checked onClick="PatientReady (this,'111','PatientReady')">

you want to use "this" to reference the actual object, if the funciton were using a 'getElementById' function call, then you would be good, but it's not

answered Sep 1, 2009 at 18:56

Jay

5,0434 gold badges30 silver badges42 bronze badges

Comments

Gregoire · Accepted Answer · 2009-09-01 18:53:14Z

0

you have double quote both for delimiting and in your onclick event

answered Sep 1, 2009 at 18:53

Gregoire

25k7 gold badges50 silver badges74 bronze badges

Collectives™ on Stack Overflow

Firebug giving me a syntax error in OnClick function

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related