javascript code making url link undefined

Question

I am working on this javascript code and when is goes in the head and I refresh it goes to a 404 page.

Please can someone help.

<script type="text/javascript">
function recordOutboundLink(link, category, action) {
    try {
        var myTracker = _gat._getTrackerByName();
        _gaq.push(['myTracker._trackEvent', category, action]);
        setTimeout('document.location = "' + link.href + '"', 100)
    } catch (err) { }
}
$(document).ready(function () { $('#myid').click(recordOutboundLink(this, 'regular   xxxxx', 'xxxx.example.com')); });
 </script>

Ja͢ck · Accepted Answer · 2012-12-12 12:34:49Z

3

You're trying to register the result of recordOutboundLink() as a click handler, causing the function to run first, evaluating window.href as the page to redirect to. The value of window.href is typically undefined, so the browser will try to redirect to http://undefined or something similar.

Instead, you should only execute the function when something is clicked, like so:

$(document).ready(function () { 
    $('#myid').click(function() {
        recordOutboundLink(this, 'regular   xxxxx', 'http://xxxx.example.com');
        return false;
    });

I believe the Google docs mention something like this:

<a href="bla bla" onclick="recordOutboundLink(this, 'regular crap', 'http://www.example.com'); return false;">tada click me</a>

Edit

Your locations should always be absolute, i.e. start with http://, https:// or simply //.

edited Dec 12, 2012 at 12:34

answered Dec 3, 2012 at 13:07

Ja͢ck

174k39 gold badges269 silver badges317 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

jelly46 Over a year ago

Thanks Jack, I can't edit the HTML on this specific issue (cms plugin), so I only have access to the JS in the head. Thanks

Ja͢ck Over a year ago

@jelly46 Is there a reason why you changed the accepted answer? Didn't it work?

bPratik · Accepted Answer · 2012-12-03 13:08:03Z

1

You need to pass the complete url to the method, ie, with the http:// part

so either use:

.click(recordOutboundLink(this, 'regular   xxxxx', 'http://xxxx.example.com'))

or

.click(recordOutboundLink(this, 'regular   xxxxx', '//xxxx.example.com'))

answered Dec 3, 2012 at 13:08

bPratik

7,0114 gold badges40 silver badges70 bronze badges

1 Comment

jelly46 Over a year ago

Hello thanks for that, I did that but i am still getting the same problem.

Collectives™ on Stack Overflow

javascript code making url link undefined

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related