JQuery: Trouble with simple slideshow

Question

I'm having trouble with a super simple slideshow I'm trying to make. I can't figure out why it won't work. The first picture shows up but it does not cycle through.

Here is the JSFiddle: http://jsfiddle.net/cydonknight/kyhxy/

and the JQuery:

<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js"></script>

        <script type="text/javascript">
        $(document).ready(function(){
            setInterval("rotateImages()", 2000   );
        });
        function rotateImages(){
            var $onCurrent= $('#imageSlider div.current') ;


            var $onNext= $onCurrent.next().length ? $onCurrent.next();
                : $('#imageSlider div:first');

            if (!onNext.length )
                onNext=$("#imageSlider div:first");

            $onCurrent.addClass('previous');
            $onNext.css({opacity: 0.0}).addClass('current').animate({opacity:1.0}, 2000, function() {
                    $onCurrent.removeClass(' previous');
                    });


            }

    </script>

Any help would be greatly appreciated!

yes. i am trying. bug in this line. $onCurrent.next(); no semicolon here. — Sathya
– Sathya, Commented Dec 5, 2012 at 5:52

Sathya · Accepted Answer · 2012-12-05 06:08:06Z

2

It is working now. I did lot of changes actually.

your updated fiddle

    setInterval(rotateImages, 2000);

function rotateImages()
{
var $onCurrent= $('#imageSlider div.current') ;
var $onNext= $onCurrent.next().length ? $onCurrent.next() : $('#imageSlider div:first');   

if (!$onNext.length )
    $onNext=$("#imageSlider div:first");

$("#imageSlider div").removeClass("current").css("opacity", 0);
$onNext.addClass('current').animate({opacity:1.0}, 1000);
}

answered Dec 5, 2012 at 6:08

Sathya

5,3148 gold badges45 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

JQuery: Trouble with simple slideshow

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related