Rails remote call not working / javascript format

Question

bit new to Ajax and rails.

I have a link on an image that when clicked should replace the image.

Here's my link in the view:

<div id="flag_<%= message.id %>">
  <%= link_to image_tag("white_star.png"), flag_message_path(message), remote: true %>
</div>

this calls flag method on messages controller. For format.js i have flag.js:

{$('#flag_<%[email protected]%>').html('<% if @message.flag == false %><a href="/messages/96/flag" data-remote="true"><img alt="White_star" src="/assets/white_star.png" title="flag"></a>
    <% else %>
    <a href="/messages/96/flag" data-remote="true"><img alt="Red_star" src="/assets/red_star.png" title="flag"></a>
    <% end %>');
}

this returns to the browser:

{
$('#flag_94').html('<a href="/messages/96/flag" data-remote="true"><img alt="White_star" src="/assets/white_star.png" title="flag"></a>
');
}

which seems ok to me, yet nothing happens.... Any thoughts?? thanks

was wondering if it is anything to do with the quotation marks, but can't get it right — bobomoreno
– bobomoreno, Commented Dec 16, 2012 at 14:30

nathanvda · Accepted Answer · 2012-12-16 15:11:15Z

1

Everything seems ok, but I would drop the surrounding accolades in your format.js.erb. Those are not needed.

If there is an error in your javascript, you should see it in the javascript console.

It is generally good practice to extract code like this into a partial.

So you would have a replace_image.html.erb :

<% if @message.flag == false %>
  <a href="/messages/96/flag" data-remote="true"><img alt="White_star" src="/assets/white_star.png" title="flag"></a>
<% else %>
  <a href="/messages/96/flag" data-remote="true"><img alt="Red_star" src="/assets/red_star.png" title="flag"></a>
<% end %>

and in your format.js.erb you would just do

$('#flag_<%[email protected]%>').html("<%= escape_javascript(render :partial => 'replace_image') %>");

Hope this helps.

answered Dec 16, 2012 at 15:11

nathanvda

50.1k14 gold badges120 silver badges140 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

bobomoreno Over a year ago

Thanks!! escaping seems to have done the trick, also had some \n floating in there.

Collectives™ on Stack Overflow

Rails remote call not working / javascript format

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related