Nested while loop not looping?

Question

Here's the code:

while (keepGoingDay.equals("y") || keepGoingDay.equals("y")){
        System.out.println(acct1);
        System.out.println(acct2);
        Account.reset();

        while (keepGoing.equals("y") || keepGoing.equals("y"))
            {
            //get account number, what to do, and amount
            System.out.print("\nEnter the number of the account you would like to access: ");
            acctNumber = scan.nextLong();
            System.out.print("Would you like to make a deposit (D) or withdrawal (W)? ");
            action = scan.next();
            System.out.print("Enter the amount: ");
            amount = scan.nextDouble();

            if (amount > 0)
                if (acctNumber == acct1.getAcctNumber())
                if (action.equals("w") || action.equals("W"))
                    acct1.withdraw(amount);
                else if (action.equals("d") || action.equals("D"))
                    acct1.deposit(amount);
                else 
                    System.out.println("Sorry, invalid action.");
                else if (acctNumber == acct2.getAcctNumber())
                if (action.equals("w") || action.equals("W"))
                    acct1.withdraw(amount);
                else if (action.equals("d") || action.equals("D"))
                    acct1.deposit(amount);
                else 
                    System.out.println("Sorry, invalid action.");
                else
                System.out.println("Sorry, invalid account number.");
            else
                System.out.println("Sorry, amount must be > 0.");


            System.out.print("\nMore transactions? (y/n)");
            keepGoing = scan.next();        
            }
        System.out.println("End of day stats: ");
        System.out.println("Number of deposits: " + Account.getNumDeposits());
        System.out.println("Number of withdrawals: " + Account.getNumWithdrawals());
        System.out.println("Total value of deposits: " + Account.getTotalDeposits());
        System.out.println("Total value of withdrawals: " + Account.getTotalWithdrawals());
        System.out.print("More days?");
        keepGoingDay = scan.next();
         }

}

I don't think the methods are too essential to this so I'll leave them out to save space.

The goal of this program is to have transactions be recorded and counted for multiple days (unknown amount so I couldn't use a for loop).

It goes through the first run fine and after that, it skips over the inner while loop.

I've looked at the braces and don't think that's the issue.

They're not tautologies, they're just redundant (i.e., A or A). — Travis Addair
– Travis Addair, Commented Dec 17, 2012 at 5:48
I think you mean to check that keepGoing/keepGoingDay are either "y" or "Y". Instead of doing that explicitly, just use keepGoing.equalsIgnoreCase("y"). — Travis Addair
– Travis Addair, Commented Dec 17, 2012 at 5:49
That's how it was in the skeleton program, so I am not really inclined to change that — user1740066
– user1740066, Commented Dec 17, 2012 at 5:49

Bohemian · Accepted Answer · 2012-12-17 05:50:20Z

1

Did you mean Y or y:

while (keepGoing.equals("Y") || keepGoing.equals("y"))

You code was testing the same thing, ie y, twice.

FYI, your tests could be simplified to:

while (keepGoing.equalsIgnoreCase("y"))

answered Dec 17, 2012 at 5:50

Bohemian♦

427k103 gold badges604 silver badges750 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user1740066 Over a year ago

As I mentioned above, it's an issue with the skeleton program I was given (was given the actual file, I didn't need to transcribe it) so I'll bring it up with the course teacher tomorrow. Also, that does not fix my loop problem unfortunately.

someone · Accepted Answer · 2012-12-17 05:58:30Z

0

put scan.next(); after your acctNumber = scan.nextLong(); line and amount = scan.nextDouble(); line.

Like this. check my newly added lines.

            System.out.print("\nEnter the number of the account you would like to access: ");
            acctNumber = scan.nextLong();
            scan.next(); // newly added
            System.out.print("Would you like to make a deposit (D) or withdrawal (W)? ");
            action = scan.next();
            System.out.print("Enter the amount: ");
            amount = scan.nextDouble();
            scan.next(); // newly added

answered Dec 17, 2012 at 5:58

someone

6,5728 gold badges43 silver badges63 bronze badges

2 Comments

user1740066 Over a year ago

I don't get it, what does that do?

someone Over a year ago

nextLong() and nextDouble only read the long and double value. So when you continue reading with next you receive the "\n" Enter key. So to skip this you have to add the next().

user1740066 · Accepted Answer · 2012-12-17 07:07:18Z

0

If I had the flexibility to change the skeleton program, I would have used boolean variables.

However, the solution that you have to put in place is to reset keepGoing to "y" because it was set to "n" causing it to be skipped.

answered Dec 17, 2012 at 7:07

user1740066

1411 gold badge1 silver badge9 bronze badges

Collectives™ on Stack Overflow

Nested while loop not looping?

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related