Codeigniter not allowing the user to add duplicate emails to the db

Question

I am trying to pull in the users table and if the email is already in the database, i don't want the user to be able to add another row with the same email. The below code is what I've put together so far but it doesn't seem to work correctly. Does anybody notice what I am doing wrong?

    $email = $this->input->post('email');
    $password = $this->input->post('password');
    $firstname = $this->input->post('firstname');
    $lastname = $this->input->post('lastname');
    $usersAddress = $this->input->post('usersAddress');
    $usersCity = $this->input->post('usersCity');
    $usersState = $this->input->post('usersState');
    $phoneNumber = $this->input->post('phoneNumber');

    $query1 = $this->db->get('users');
    foreach($query1->result() as $row) {    
        if ($row->email == $email) {
            echo 'Sorry but this email is already in use. Please go back and use a different email.';
        } else {
            $data = array('email' => $email,
                          'password' => $password,
                          'firstname' => $firstname,
                          'lastname' => $lastname,
                          'usersAddress' => $usersAddress,
                          'usersCity' => $usersCity,
                          'usersState' => $usersState,
                          'phoneNumber' => $phoneNumber);
            $this->db->insert('users', $data); 
            $this->session->set_userdata('id', $this->db->insert_id());
            $this->session->set_userdata('logged', 'true');
            $this->session->set_userdata('firstname', $firstname);
            $this->session->set_userdata('lastname', $lastname);
            $this->session->set_userdata('email', $email);
            mail($email,"KyPlays.org","You have successfully regstered at KyPlays.org");
            header("Location: ".base_url()."index.php/routers/startpage?requestedPageType=regPart2");
        }
    }

don't get all the users, check if the single email address is in the db or not. — user557846
– user557846, Commented Dec 20, 2012 at 0:52
both, no need for the loop, check for the email, then do your if\else according to the the result — user557846
– user557846, Commented Dec 20, 2012 at 0:56
your code does add for each row a new entry if email not match. just think it over @Dogan +1 — Sir Rufo
– Sir Rufo, Commented Dec 20, 2012 at 1:01

leepowers · Accepted Answer · 2012-12-20 01:01:33Z

4

No need for the loop. Just check if the email is being used:

$query = $this->db->get_where('users', array('email' => $email));
if ($query->num_rows() > 0) {
  // Show error message as email already exists in the database
} else {
  // Insert new user
}

answered Dec 20, 2012 at 1:01

leepowers

38.4k24 gold badges103 silver badges132 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Michael Grigsby Over a year ago

Thanks man. Yeah I just got done rewriting it like how you have it written and it works perfectly now.

TheDayIsDone · Accepted Answer · 2012-12-23 00:01:38Z

3

you could also use the built in form_validation and use something like:

$this->form_validation->set_rules('email', 'Email','required|valid_email|is_unique[users.email]');

see also: http://ellislab.com/codeigniter/user-guide/libraries/form_validation.html

answered Dec 23, 2012 at 0:01

TheDayIsDone

3235 silver badges11 bronze badges

Collectives™ on Stack Overflow

Codeigniter not allowing the user to add duplicate emails to the db

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related