Model is null when form submitted

Question

When I hit submit, the file parameter is null.

public ActionResult Create()
{
  return View(new FileViewModel());
}

[HttpPost]    
[InitializeBlobHelper]
public ActionResult Create(FileViewModel file)
{
  if (ModelState.IsValid)
  {
     //upload file
  }
  else
    return View(file);
}

public class FileViewModel
{
  internal const string UploadingUserNameKey = "UserName";
  internal const string FileNameKey = "FileName";

  internal const string Folder = "files";

  private readonly Guid guid = Guid.NewGuid();

  public string FileName
  {
    get
    {
      if (File == null)
        return null;
      var folder = Folder;
      return string.Format("{0}/{1}{2}", folder, guid, Path.GetExtension(File.FileName)).ToLowerInvariant();
    }
  }

  [RequiredValue]
  public HttpPostedFileBase File { get; set; }
}

Here is the cshtml:

@model MyProject.Controllers.Admin.FileViewModel

@{
  ViewBag.Title = "Create";
  Layout = "~/Views/Shared/_BackOfficeLayout.cshtml";
}

@using (Html.BeginForm("Create", "Files", FormMethod.Post, new { enctype = "multipart/form-data" }))
{
  <fieldset>
    <legend>Create</legend>

    <div class="editor-label">
      @Html.LabelFor(model => model.File)
    </div>
    <div class="editor-field">
      @Html.TextBoxFor(model => model.File, new { type = "file" })
      @Html.ValidationMessageFor(model => model.File)
    </div>

    <p>
      <input type="submit" value="Create" />
    </p>
  </fieldset>
}

<div>
  @Html.ActionLink("Back to List", "Index")
</div>

Shimmy Weitzhandler · Accepted Answer · 2012-12-20 10:40:56Z

73

It's naming conflict and binder trying to bind your File property to FileViewModel object with file name, that's why you get null. POST names are case-insensitive.

Change:

public ActionResult Create(FileViewModel file)

To:

public ActionResult Create(FileViewModel model)

or to any other name

edited Dec 20, 2012 at 10:40

Shimmy Weitzhandler

105k126 gold badges437 silver badges645 bronze badges

answered Dec 20, 2012 at 9:32

webdeveloper

17.3k3 gold badges51 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Shimmy Weitzhandler Over a year ago

Shiat! I didn't believe it's gonna work but it did. Why indeed did this happen?

webdeveloper Over a year ago

@Shimmy It's naming conflict and binder trying to bind your File property to FileViewModel object with file name, that's why you get null. POST names are case-insensitive.

Neelam Prajapati Over a year ago

i am getting sort of same error.but i dont get your solution

Pratyush Dhanuka Over a year ago

thanks, was stuck in hours could not figure why it stopped working suddenly

Wildcat Matt Over a year ago

This is particularly insidious when you go back to modify older code written by someone else. I never use "model" by itself as an object name and added a "Model" field to a nested object containing vehicle information, so code that worked for 7 years suddenly broke for no immediately obvious reason.

|

ransems · Accepted Answer · 2017-09-09 11:02:53Z

3

This solved my issue as well. It was a name that I was using that was similar to the model, which was similar to the variable I assigned the posted model too. once I sorted out the field name all worked as expected.

Of course the error was not helpful in pointing this out.

answered Sep 9, 2017 at 11:02

ransems

6718 silver badges20 bronze badges

Collectives™ on Stack Overflow

Model is null when form submitted

2 Answers 2

7 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related