Javascript issues form values and windows

Question

I'm trying to create a form where a user enters a username, and then clicks a button. Then it opens a window with the parameters in the url like so below.

<script type="javascript">
function open(id) {
    window.open("http://linkhere.com/~Robby/lcpVote.php?u="+ document.getElementById(id).innerHTML +"&s=" + id + "&a=addVote");
}
</script>
<input type="text" placeholder="MC Username" id="name" style="width:100%">

And when they click on the button below,

<button class="btn btn-primary" style="width:100%" onclick="open('1')" id="1" href="#">MCServers.org</button>

It opens the following url

http://LINKHERE.COM/~Robby/lcpVote.php?u=USERNAMEFROMFORM&s=IDFROMBUTTON&a=addVote

But when I click it using my code it just returns a white page?

Is that HTML5? Otherwise numeric id is not allowed. Also, you're not properly escaping your query string parameters. — Ja͢ck
– Ja͢ck, Commented Dec 30, 2012 at 5:45
What do you mean by that? I'm absolutely TERRIBLE with javascript. — user1484136
– user1484136, Commented Dec 30, 2012 at 5:46
Also please...for the future of htmls purpose, please end your input tag as /> rather than just > hahaha — Charles
– Charles, Commented Dec 30, 2012 at 5:49

jeremy · Accepted Answer · 2012-12-30 15:12:46Z

2

Use method="get" on the form. This will make the query string suitable to what you want depending on the input names within your form.

edited Dec 30, 2012 at 15:12

jeremy

10.1k4 gold badges41 silver badges61 bronze badges

answered Dec 30, 2012 at 5:47

user1484136

Sign up to request clarification or add additional context in comments.

Comments

Charles · Accepted Answer · 2012-12-30 05:48:06Z

1

it is because you are passing in 1 as an id in your onclick function. You should instead pass in the id of the input field. So it should be:

<button class="btn btn-primary" style="width:100%" onclick="open('name')" id="1" href="#">MCServers.org</button>

Where name is your input fields id.

answered Dec 30, 2012 at 5:48

Charles

6482 gold badges9 silver badges24 bronze badges

Comments

Adeel Ahmed · Accepted Answer · 2012-12-30 06:14:10Z

1

Replace innerHTML by value..

window.open("http://linkhere.com/~Robby/lcpVote.php?u="+ document.getElementById(id).value+"&s=" + id + "&a=addVote");

and replace 1 by name..

<button class="btn btn-primary" style="width:100%" onclick="open('name')" id="1" href="#">MCServers.org</button>

answered Dec 30, 2012 at 6:14

Adeel Ahmed

1,6019 silver badges10 bronze badges

Collectives™ on Stack Overflow

Javascript issues form values and windows

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related