Changes entire array instead of one cell

Question

I have a 2D array of PictureBox, and I want in a loop to change each picturebox's location and add it to the form, but when I change one cell's property it changes every one of the other cells too. (The constructor gets the form's object and sets it to form variable)

private Form form;
private PictureBox[,] board = new PictureBox[8, 8];
private void PrintBoard()
    {
        for (int i = 0; i < 8; i++)
        {
            for (int j = 0; j < 8; j++)
            {
                board[i, j].Left = j * 20;
                form.Controls.Add(board[i, j]);
            }
        }
    }

Where are you getting i from?

PhoenixReborn
– PhoenixReborn

2013-01-03 17:02:38 +00:00
Commented Jan 3, 2013 at 17:02 — PhoenixReborn
– PhoenixReborn, Commented Jan 3, 2013 at 17:02
seems he missed one for loop

Tilak
– Tilak

2013-01-03 17:03:15 +00:00
Commented Jan 3, 2013 at 17:03 — Tilak
– Tilak, Commented Jan 3, 2013 at 17:03
oops sorry, I did miss the loop

Nathan Abramov
– Nathan Abramov

2013-01-03 17:10:44 +00:00
Commented Jan 3, 2013 at 17:10 — Nathan Abramov
– Nathan Abramov, Commented Jan 3, 2013 at 17:10
@NathanAbramov how do you add picture boxes to board?

Sergey Berezovskiy
– Sergey Berezovskiy

2013-01-03 17:14:09 +00:00
Commented Jan 3, 2013 at 17:14 — Sergey Berezovskiy
– Sergey Berezovskiy, Commented Jan 3, 2013 at 17:14

Sergey Berezovskiy · Accepted Answer · 2013-01-03 17:11:02Z

2

I think problem is in filling array of picture boxes - you are adding reference to same picture box to all cells. You should create new PictureBox for each cell:

for(int i = 0; i <= board.GetUpperBound(0); i++)
    for (int j = 0; j < board.GetUpperBound(1); j++)
        board[i, j] = new PictureBox(); // create new picture box for each cell

edited Jan 3, 2013 at 17:11

answered Jan 3, 2013 at 17:05

Sergey Berezovskiy

237k44 gold badges441 silver badges468 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Nathan Abramov Over a year ago

And by the way, I use this in the form as a reference of the form object, how can i get the reference without the this, and in another calss?

Nathan Abramov Over a year ago

"the method has some invalid arguments"

Sergey Berezovskiy Over a year ago

@NathanAbramov can you post code which you have problems with?

Nathan Abramov Over a year ago

class a{ Game game = new Game(this); } Im creating a new instance of the Game object from a calss, and i cant use this

Sergey Berezovskiy Over a year ago

let us continue this discussion in chat

Collectives™ on Stack Overflow

Changes entire array instead of one cell

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related