Dynamic php variable in mysql INSERT query

Question

I am taking values from my form that has 39 fields, all fields have name's order as

field1,field2,field3 .......

and my sql table mytable also have 39 fields with the same name i.e. field1,field2,field3 .......

Now in the submit.php I am looking for a solution where I don't want to write all these 39 variables to store in mytable i.e. INSERT INTO mytable VALUES(field1,field2,field3,......)

But I am looking for a solution in which I don't have to write all these 39 variables and still I can store them in different 39 fields of sql. What I've tried is:

$query=mysql_query("INSERT INTO mytable VALUES (
".
for ($k=1; $k<=39; $k++)
{

$vari=$_POST["field".$k];   


$Temp_previous_total++;

}
.")");

Is there a question in there somewhere? Is it why your example code didn't work, for which there a various reasons :P. — Jonnix
– Jonnix, Commented Jan 9, 2013 at 17:20

mpaepper · Accepted Answer · 2013-01-09 17:58:51Z

2

$myvars = '';
for ($k=1; $k<=39; $k++)
{
   $myvars .= "'".$_POST["field".$k]."',";   
}
$myvars = substr($myvars,0,-1);
$query = "INSERT INTO mytable VALUES (
".$myvars.")";
mysql_query($query);

edited Jan 9, 2013 at 17:58

answered Jan 9, 2013 at 17:21

mpaepper

4,0324 gold badges23 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

mpaepper Over a year ago

This is how your code should work. But keep in mind this is very bad practice as mentioned by keeg

mpaepper Over a year ago

@JonStirling there are commas separating in the for loop?

Jonnix Over a year ago

Ugh, talk about me getting the wrong end of the stick with my last comment :/. Anyway, might be worth assuming that the OPs fields are actually text inputs and quote accordingly but meh, it's not specifically an issue without more context.

Muhammad Arslan Jamshaid Over a year ago

Column count doesn't match value count at row 1 , I counted both of them are 39 39

mpaepper Over a year ago

@Programer I also updated the code to reflect the quotes suggested by Jon, try if that works.

|

keeg · Accepted Answer · 2013-01-09 17:20:56Z

1

You should definitely sanitize those fields before you insert them, here is a really helpful class for mysql queries: PHP MySQL wrapper v3 that does exactly that

answered Jan 9, 2013 at 17:20

keeg

3,9589 gold badges51 silver badges101 bronze badges

Collectives™ on Stack Overflow

Dynamic php variable in mysql INSERT query

2 Answers 2

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related