Stack overflow for recursive count of elements in java

Question

I'm trying to count the number of Ones in the binary representation of an integer. I need to do this recursively. I think my logic is correct but I continue to get a stack overflow. I'm on day 2 troubleshooting. Here's my code:

    static int CountRecursive(int n) {
    int sum = 0;
    if (n >= 0) {
        if (n%2 == 1) {
            sum ++;
        } sum += CountRecursive(n/2);
    } return sum;
}

My logic is based on this information: "The standard mechanism for converting from decimal to binary is to repeatedly divide the decimal number by 2 and, at each division, output the remainder (0 or 1)."

Note though that you have to tweak your solution even more to work for negative integers too. — biziclop
– biziclop, Commented Jan 12, 2013 at 0:14

Ivaylo Strandjev · Accepted Answer · 2013-01-11 23:52:13Z

11

Remove the equals in the if. 0 divided by 2 is still zero - you go into infinite recursion.

I mean make this one:

if (n >= 0)

strict comparison i.e:

if (n > 0)

answered Jan 11, 2013 at 23:52

Ivaylo Strandjev

71.4k18 gold badges130 silver badges183 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Stack overflow for recursive count of elements in java

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related