Why can't I pass a string as a parameter in a Javascript function?

Question

I have the following code in php:

<?php
$apples = 123123;
echo "<td>
         <input type='button' onclick='confirmation($apples)' value='ac/in'>
      </td>";

echo('<script type="text/javascript">
           function confirmation(test) {
              var answer = confirm("Are you sure?")
              if (answer){
                  alert(test);
                  $.get("/index.php?f=func_name_to_call", 
                  {name: "John", hobby: "Programming"}, function(data) {});
              }
           }
</script>');
?>

If $apples is a number then the parameter gets passed correctly; however when it is a string, the function confirmation() is broken. Any ideas? Thanks in advance.

If you send a string, it must be treated like so. Quote it.

Alfabravo
– Alfabravo

2013-01-23 05:21:28 +00:00
Commented Jan 23, 2013 at 5:21 — Alfabravo
– Alfabravo, Commented Jan 23, 2013 at 5:21

Yogesh Suthar · Accepted Answer · 2013-01-23 05:20:34Z

7

If you want it to pass argument as string use the below edited code

echo "<td><input type='button' onclick='confirmation(\"$apples\")' value='ac/in'></td>";

Just use \ for escaping the double quotes,and it will be considered as a string.

answered Jan 23, 2013 at 5:20

Yogesh Suthar

30.5k18 gold badges75 silver badges100 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Supericy Over a year ago

Alternatively, you could use json_encode($apples). It will quote the variable for you if it is a string. As well as let you pass more complicated data structures (such as an associative array) into javascript.

Supericy Over a year ago

It will also escape the string for you as well.

BenMorel · Accepted Answer · 2014-01-02 16:25:29Z

2

Yes you have to use escape character \" \" in calling confirmation function because you pass integer in a integer type parameter which is without double quotes.therefore it converts the string into integer...

edited Jan 2, 2014 at 16:25

BenMorel

37.1k52 gold badges208 silver badges339 bronze badges

answered Jan 23, 2013 at 5:34

gcsforum

211 bronze badge

Comments

ianace · Accepted Answer · 2013-01-23 05:54:58Z

1

<?php
$apples = 123123;
?>
<td>
    <input type='button' onclick='confirmation(<?php echo $apples?>)' value='ac/in'>
</td>

<script type="text/javascript">
    function confirmation(test) {
        var answer = confirm("Are you sure?")
        if (answer){
            alert(test);
            $.get("/index.php?f=func_name_to_call", 
            {name: "John", hobby: "Programming"}, function(data) {});
        }
    }
</script>

you'll run into the trouble of converting all those ' into " since your echoing them by php, just an advice dont echo them, use the html markup and just escape your php

answered Jan 23, 2013 at 5:54

ianace

1,6352 gold badges17 silver badges32 bronze badges

Collectives™ on Stack Overflow

Why can't I pass a string as a parameter in a Javascript function?

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related