Add data to ArrayList android

Question

In logcat I am getting a null pointer exception for this code sample. I am trying to add the e.g oneObject.has(TAG_TITLE) inside an Arraylist but when I print currentPost.getid() for example i am getting this nullpointer excepttion. Can someone help me please.

// getting JSON string from URL

JSONArray jArray = jParser.getJSONFromUrl(url);
ArrayList<Post> PostList = new ArrayList<Post>();
Post currentPost = new Post();

// looping through All element
for(int i = 0; i < jArray.length(); i++){
    try{
        JSONObject  oneObject = jArray.getJSONObject(i);
        // Storing each json item in variable
        if(oneObject.has(TAG_ID)){
            id = oneObject.getString(TAG_ID);
            currentPost.setId(id);
        }
        else{
            id="";
        }
        if(oneObject.has(TAG_TITLE)){
            title = oneObject.getString(TAG_TITLE);
            currentPost.setTitle(title);
        }
        else{
            title ="";
        }
        if(oneObject.has(TAG_CONTENT)){
            content = oneObject.getString(TAG_CONTENT);
            currentPost.setContent(content);
        }
        else{
            content ="";
        }
        System.out.println("postlist: "+currentPost.getId());
        PostList.add(currentPost);
        currentPost = new Post();

ρяσѕρєя K · Accepted Answer · 2013-01-24 08:05:43Z

1

you also need to set currentPost object fields values to default value if key name not exist in Json String as :

           // your code here...
            if(oneObject.has(TAG_ID)){

                id = oneObject.getString(TAG_ID);

                currentPost.setId(id);
            }
            else{

                id="DEFAULT_VALUE";
                currentPost.setId(id);  //<<<< set default value here
            }
           // your code here...

answered Jan 24, 2013 at 8:05

ρяσѕρєя K

133k54 gold badges203 silver badges216 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ρяσѕρєя K Over a year ago

@sophia : put currentPost.setId(id);System.out.println("postlist: "+currentPost.getId()); code inside else part and check you are getting value in log or not

Supreethks · Accepted Answer · 2013-01-24 08:09:50Z

0

In your code

// Storing each json item in variable

                    if(oneObject.has(TAG_ID)){

                        id = oneObject.getString(TAG_ID);

                        currentPost.setId(id);
                    }
                    else{

                        id="";
                    }

You have missed to set the Id for current oneObject.has(TAG_ID) returns false.

Best way to avoid this would be to return empty string from all your getters if the parameter is not being set.

EDIT:

Add make the change that is in bold.

// Storing each json item in variable

                    if(oneObject.has(TAG_ID)){

                        id = oneObject.getString(TAG_ID);

                        currentPost.setId(id);
                    }
                    else{

                        id=""; 
                        **currentPost.setId(id);**
                    }

edited Jan 24, 2013 at 8:09

answered Jan 24, 2013 at 8:00

Supreethks

6077 silver badges16 bronze badges

2 Comments

Dimitri Over a year ago

i don't understand, elaborate please

Supreethks Over a year ago

You are setting the post id by calling currentPost.setId(id) if oneObject.has(TAG_ID) is true but not setting it when it is false. Check my answer I have edited it.

Collectives™ on Stack Overflow

Add data to ArrayList android

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related