Form not inserting information into mysql table?

Question

Hi i'm having a problem with my forum comment form. Basically i am trying to allow a user to read a users post and comment on it, the form data is suppose to be inserted into mysql.

the values i need inserted are the comment_id which is the session id of the user and the post_id the id of the post their commenting on and the content which they type.

For some reason this is not being inserted into mysql and is coming up with my echoed success message without any errors. can someone please show me where im going wrong.

Thanks

<?php
        $page_title = "Read Post";
        include('includes/header.php'); 
        include ('includes/mod_login/login_form2.php');  ?>

        <?php
        confirm_logged_in();



        if (isset ($_GET['post'])) {
        $forum_id = $_GET['post'];
    }

    ?>

    <?php include('includes/copyrightbar.php'); ?>
    <?
    $read_forum_set = read_forum_set();
            while ($forum = mysql_fetch_array($read_forum_set)) {?>
    <div class="modtitle">
    <div class="modtitle-text"><?php echo "{$forum['display_name']}"; ?>'s Forum Post</div>
    <? } ?>
    </div>

    <div class="modcontent57">


    <br /><br /><br/><br/>

    <div class="forum">
    <div class="forum-pic"><?php echo "<img src=\"data/photos/{$_SESSION['user_id']}/_default.jpg\" width=\"100\" height=\"100\" border=\"0\" align=\"right\" class=\"img-with-border-forum\" />";?>
    </div>

    <div class="message-links">
    <strong><a href="forum.php"><< Back to Forum</a>
    </div> 
    <br /><br /><br/><br/>
    <?php 

        $datesent1 = $forum['date_sent'];  ?>

    <?php
            $read_forum_set = read_forum_set();
            while ($forum = mysql_fetch_array($read_forum_set)) {
            $prof_photo = "data/photos/{$forum['user_id']}/_default.jpg";

            $result = mysql_query("UPDATE ptb_forum SET ptb_forum.read_forum='1' WHERE ptb_forum.id='$forum'") 
    or die(mysql_error()); 

    ?>
    <div class="message-date">
    <?php echo "".date('D M jS, Y  -  g:ia', strtotime($forum['date_sent'])).""; ?></div>



    <div class="img-with-border-frm-read"><?php echo "<a href=\"profile.php?id={$forum['from_user_id']}\"><img width=\"60px\" height=\"60px\" src=\"{$prof_photo}\"></a><br />"; ?></div>



    <?php echo "<div class=\"forum-content2\"><div class=\"forum_subject\"><strong>Subject:</strong></div><div class=\"forum_subject2\"><i>{$forum['title']}</i></div><div class=\"forum_body\"><strong>Post:<br/></strong></br ><i>{$forum['content']}</i></div></div>";?>



     <?php 
    // check if the review form has been sent
    if(isset($_POST['forum_comment']))
    {
        $content = $_POST['forum_comment'];
            //We remove slashes depending on the configuration
            if(get_magic_quotes_gpc())
            {
                    $content = stripslashes($content);
            }
            //We check if all the fields are filled
            if($_POST['forum_comment']!='')
            {


                {
                $sql = "INSERT INTO ptb_forum_comments (comment_id, post_id, content) VALUES (NULL, '".$_SESSION['user_id']."', '".$profile_id."', '".$content."');";
                mysql_query($sql, $connection);

                echo "<div class=\"infobox-profile4\"><strong>Thank You</strong> - Your review has been sent for approval.</div>";
            } }
    }

    ?> 


     <?php if(isset ($_SESSION['user_id'])) { ?>



    <div class="forum-comment-box">
    <form action="<?php $_SERVER['PHP_SELF'] ?>" method="post">
    <textarea name="forum_comment" id="forum_comment" style="resize:none; height:100px; width:543px;"></textarea><input type="submit" name="send_button" id="send_button" style="float:right; margin-right:30px; text-align:center;" value="Reply to {$message['display_name']}" /></form></div>

    <? } } ?>


          </div>
          </div>



    <?php include('includes/footer.php'); ?>
    </div>

Are you sure your $_POST if statements are going through? (ie, are you sure you are posting back correctly?) I don't see any reason for it not to be, but I also don't see why you're not receiving an error if the SQL isn't being executed properly.. — StuckAtWork
– StuckAtWork, Commented Feb 5, 2013 at 19:07
Please, don't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. If you choose PDO, here is a good tutorial. — ROY Finley
– ROY Finley, Commented Feb 5, 2013 at 19:21

Mateusz Rogulski · Accepted Answer · 2013-02-05 19:10:19Z

1

You have some missing table names here:

$sql = "INSERT INTO ptb_forum_comments (comment_id, post_id, content) VALUES (NULL, '".$_SESSION['user_id']."', '".$profile_id."', '".$content."');";

as you can see you have 3 tables names and 4 values.

answered Feb 5, 2013 at 19:10

Mateusz Rogulski

7,4638 gold badges47 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Robert Taylor Over a year ago

fixed it by removing null from the values. cheers, is there any reason why it is not getting the users profile_id by which i mean the user who's post it is and submitting this to mysql?

Collectives™ on Stack Overflow

Form not inserting information into mysql table?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related