Async.parallel with an array of tasks

Question

I am having an issue figuring out how to make an array of functions with different parameters. I am using coffeescript and async but I think it is a problem with my understanding of javascript.

I want to create an array of functions with different tasks.

names = ['Jeff', 'Maria', 'Steve']
tasks = []

for name in names
  tasks.push (callback)=>
      @controller.get_person name, (person) =>
        callback(null, person)

async.parallel(tasks, cb)

The problem is that the task is getting called with Steve (always the one that is last in the array) three times. How do I make it so that there is one task per each name?

possible duplicate of Javascript closure inside loops - simple practical example — Bergi
– Bergi, Commented Feb 5, 2013 at 20:05
possible duplicate of Closure Scope not captured? — Coffeescript — mu is too short
– mu is too short, Commented Feb 5, 2013 at 20:16
@Bergi offers a general JavaScript solution that will also apply to CoffeeScript, my duplicate includes the CoffeeScript-specific do keyword. Take your pick. — mu is too short
– mu is too short, Commented Feb 5, 2013 at 20:17

Linus Thiel · Accepted Answer · 2013-02-06 14:29:25Z

1

Actually, in this particular case, you should probably make use of async's map:

getPerson = (name, callback) =>
  @controller.get_person name, (person) ->
    callback(null, person)

async.map names, getPerson, (err, persons) ->
  // Do stuff with persons

Note that if your @controller.get_person method followed the node practice of passing any errors as the first parameter to the callback, this would suffice:

async.map names, @controller.get_person, (err, persons) ->
  // Do stuff with persons

Something to keep in mind, perhaps.

edited Feb 6, 2013 at 14:29

answered Feb 6, 2013 at 11:55

Linus Thiel

39.3k9 gold badges112 silver badges104 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Alexis Over a year ago

very nice! Thank you. The first way works beautifully. The second way looks awesome. However, in the second way, the @controller does not seem to get passed through to the map function. What I mean by this is that the @ seems to get rebound and looses the reference to controller. Is there a way to fix this?

Linus Thiel Over a year ago

@Scoop: Yes, you need to declare get_person with the fat arrow (=>) so it will always be bound to the object (in the class definition of whatever @controller is).

Plynx · Accepted Answer · 2013-02-05 20:38:50Z

1

Try changing for name in names to names.forEach (name)=>. Be careful of the space after forEach.

names = ['Jeff', 'Maria', 'Steve']
tasks = []

names.forEach (name)=>
  tasks.push (callback)=>
      @controller.get_person name, (person) =>
        callback(null, person)

async.parallel(tasks, cb)

answered Feb 5, 2013 at 20:38

Plynx

11.5k3 gold badges34 silver badges34 bronze badges

Collectives™ on Stack Overflow

Async.parallel with an array of tasks

2 Answers 2

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related