How to Create a Loop Here? C++

Question

Here is my code. I want it to ask for the name of file until it is a valid name. How will I do it? In my current code it stops after the fail.

void X() {
    string fileName;
    ifstream inFile;

    cout << "Enter the name of the file: " << endl;
    cin >> fileName;
    ifstream input;
    input.open(fileName);

    if (input.fail()) {
        cout << "Could not open the file " << fileName << endl;
    }
}

The last brace is not in the code block, you need to indent it by 4 spaces. — Tom Macdonald
– Tom Macdonald, Commented Feb 16, 2013 at 18:43

Tom Macdonald · Accepted Answer · 2013-02-16 18:35:41Z

1

void X() 
{
  string fileName;
  ifstream inFile;
  do {
    cout << "Enter the name of the file: " << endl;
    cin >> fileName;
    ifstream input;
    input.open(fileName);
    if(input.fail())
    {
       cout<< "Could not open the file "<< fileName<< endl;
    }
  }
  while(input.fail())
}

should do the trick. That way, as long as the file open operation does not succeed, the code will keep on trying.

answered Feb 16, 2013 at 18:35

Tom Macdonald

6,6239 gold badges42 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

David G Over a year ago

Do you mean while (!input.fail())?

Tom Macdonald Over a year ago

Oops, missed that. Thanks!

Konrad Rudolph Over a year ago

The loop condition makes no sense now. It should probably be inverted so that the loop is executed until the user enters a file name that can be opened. Your first version was probably correct.

Tom Macdonald Over a year ago

Yup. I reacted too fast. It's late here. :) @David: it is while(input.fail()) because we want the loop to exit as soon as the file is opened, so only to loop if the open call failed.

Tom Macdonald Over a year ago

@Nordin: If my answer is what you were looking for, can you accept it?

Collectives™ on Stack Overflow

How to Create a Loop Here? C++

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related