Java, Bubble Sort, Arrays, Exception in thread "main" Error

Question

I have a tutorial in class today with bubble sort and I've got an error I don't know how to fix.

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 8 at BubbleSorter.main(BubbleSorter.java:24)

It is not assessed but I would like to get through it to continue on. Thank you. Below is my entire code.

public class BubbleSorter {
    public static void main(String[] args)
    {
        int i;
        int array[] = { 12, 9, 4, 99, 120, 1, 3, 10 };
        System.out.println("Array Values before the sort:\n");
        for (i = 0; i < array.length; i++)
            System.out.print(array[i] + " ");
        System.out.println();
        System.out.println();

        bubble_srt(array, array.length);

        System.out.print("Array Values after the sort:\n");
        for (i = 0; i < array.length; i++)
            ;
        System.out.print(array[i] + " ");
        System.out.println();
        System.out.println("PAUSE");
    }

    private static void bubble_srt(int[] array, int length) {
        int i, j, t = 0;
        for (i = 0; i < length; i++) {
            for (j = 1; j < (length - 1); j++) {
                if (array[j - 1] > array[j]) {
                    t = array[j - 1];
                    array[j - 1] = array[j];
                    array[j] = t;
                }
            }
        }
    }
}

Please format your code.

m0skit0
– m0skit0

2013-02-19 15:13:30 +00:00
Commented Feb 19, 2013 at 15:13 — m0skit0
– m0skit0, Commented Feb 19, 2013 at 15:13

MByD · Accepted Answer · 2013-02-19 15:15:39Z

7

You have a small mistake:

This:

for (i = 0; i<array.length; i++);
System.out.print(array[i] + " ");

should be:

//                              v - Semicolon removed
for (i = 0; i<array.length; i++)
    System.out.print(array[i] + " ");

answered Feb 19, 2013 at 15:15

MByD

138k30 gold badges269 silver badges278 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

Hunter McMillen Over a year ago

I imagine this is a formatting issue, otherwise I would have expected a different error message. i.e. symbol i does not exist in Class X

MByD Over a year ago

Well, i does exist, it was not declared in the for loop. This is kind of a gotcha I think.

Hunter McMillen Over a year ago

In either case the array out of bounds is coming from the sort itself, not printing the array afterward.

MByD Over a year ago

I don't think so, see the method that the exception occurs in: BubbleSorter.main(BubbleSorter.java:24)

Sean Landsman Over a year ago

i is actually defined at the very top of the method - @Binyamin is correct, this is the cause of the problem

|

user000001 · Accepted Answer · 2013-02-19 15:19:26Z

2

Also change

for (j = 1; j < (length - 1); j++) {

to

for (j = 1; j < length; j++) {

You left out the last element of the Array!

Output

Array Values before the sort:

12 9 4 99 120 1 3 10 

Array Values after the sort:
1 3 4 9 10 12 99 120 
PAUSE

answered Feb 19, 2013 at 15:19

user000001

33.8k14 gold badges86 silver badges113 bronze badges

Comments

KevinA · Accepted Answer · 2013-02-19 15:22:14Z

0

You need to change 2 lines

for (i = 0; i < array.length; i++)
        ;
System.out.print(array[i] + " ");

to

for (i = 0; i < array.length; i++)
    System.out.print(array[i] + " ");

and

for (j = 1; j < (length - 1); j++) {

to

for (j = 1; j < (length); j++) {

answered Feb 19, 2013 at 15:22

KevinA

6296 silver badges25 bronze badges

Comments

DotNetRussell · Accepted Answer · 2013-02-19 15:26:49Z

0

On line 18 you need to get rid of the ; or put in brackets {

answered Feb 19, 2013 at 15:26

DotNetRussell

9,87511 gold badges61 silver badges122 bronze badges

Collectives™ on Stack Overflow

Java, Bubble Sort, Arrays, Exception in thread "main" Error

4 Answers 4

10 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

10 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related