Using dereferenced Vector iterator of type string as function argument

Question

I am iterating through a vector with

std::vector<std::string>::reverse_iterator ritr;

I need to at some point find out if a string in this vector is an operator using the function

bool IsOperator(const std::string s);

When I call the function following way,

if(IsOperator(*ritr))

eclipse complains!

Candidates are: bool IsOperator(char) bool IsOperator(std::basic_string<char,std::char_traits<char>,std::allocator<char>>)

(I have an overloaded function with accepts char instead of std::string) However, it allows the operation of storing the deferenced iterator in a string

std::string str= *ritr;

What am I missing here?

Also, you might consider using references instead of string copies. — amaurea
– amaurea, Commented Feb 20, 2013 at 15:32
You need to post some more code showing the function declaration, how you're creating the iterator etc. If the iterator truly is std::vector<string>::iterator, the compiler should have no trouble disambiguating between those two functions. Also, are you saying compilation fails, or is it Eclipse CDT's parser that's showing red squiggles? — Praetorian
– Praetorian, Commented Feb 20, 2013 at 15:37
I have specified the function declaration. Yes, it is the Eclipse CDT parser with red squiggles (learnt a new word) — user592748
– user592748, Commented Feb 20, 2013 at 15:41

Andy Prowl · Accepted Answer · 2013-02-20 15:50:13Z

2

Your code is fine. Disambiguating between isOperator(char) and isOperator(string) is not a problem, because a string cannot be implicitly converted to a char.

I expect your program to compile (if it doesn't, there's something else you are not showing), while the IDE complaining with red squiggles just means that your IDE has a bug.

Also, a few remarks:

I have a function of type std::vector<std::string>

A function cannot not have type std::vector<std::string>. It can return a value of type std::vector<std::string>, or it can accept one. I guess you meant the latter.

bool IsOperator(const std::string s)

This function signature doesn't make much sense. You probably meant accepting a constant reference to an std::string object:

bool IsOperator(std::string const& s)

answered Feb 20, 2013 at 15:50

Andy Prowl

127k25 gold badges394 silver badges455 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

user592748 Over a year ago

I meant vector type. Sorry. And yes it needs to be const reference. It is a problem with eclipse. Any way to fix it?

Andy Prowl Over a year ago

@user592748: I do not use Eclipse, so I don't know unfortunately.

user592748 Over a year ago

What do you use, if I may ask?

Andy Prowl Over a year ago

@user592748: Mostly notepad :-)

Collectives™ on Stack Overflow

Using dereferenced Vector iterator of type string as function argument

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related