HTML isn't working with javascript

Question

I'm new to programming. I'm trying to call a function in html, but it isn't working. What's the problem? Thanks in advance. (Don't ask about the whole integration thing).

My HTML code:

<!DOCTYPE html>
<html>
    <head>
    <script src="IntegrationCalculator.js"></script>
    <script>
        integrationCalculator(7);
    </script>


</head>
<body>
    <p id="tester">
        Didn't work :(
    </p>
</body>

My javascript code:

var integrationCalculator = function (variable1) {
if (variable1 = 7) {
    document.getElementById("tester").innerHTML="WORKED";
}
};

This if (variable1 = 7) { should be if (variable1 == 7) {. The first one does assignment, the second does comparison. Consider using a JavaScript validator to look for these sorts of bugs. jshint.com — the system
– the system, Commented Feb 23, 2013 at 17:16
...also, keep your browser's developer console open during development. You'll see the TypeError resulting from the issue @j08691 described below. — the system
– the system, Commented Feb 23, 2013 at 17:19

ThinkingStiff · Accepted Answer · 2013-02-23 17:25:44Z

2

Two things. First if (variable1 = 7) should be if (variable1 == 7). Second, call your function after the element is loaded in the DOM.

<!DOCTYPE html>
<html>
    <head>
    <script src="IntegrationCalculator.js"></script>
</head>
<body>
    <p id="tester">
        Didn't work :(
    </p>
    <script>
        integrationCalculator(7);
    </script>
</body>

jsFiddle example

edited Feb 23, 2013 at 17:25

ThinkingStiff

65.4k31 gold badges148 silver badges241 bronze badges

answered Feb 23, 2013 at 17:17

j08691

208k33 gold badges269 silver badges281 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

j08691 Over a year ago

Hope it helped. If you feel this answered your question, you may want to mark it as the accepted answer.

Idan Yadgar · Accepted Answer · 2013-02-23 17:20:52Z

0

integrationCalculator is called before the tester paragraph is created. Therefore, an error is thrown and the execution of the script is stopped.

answered Feb 23, 2013 at 17:20

Idan Yadgar

1,0341 gold badge7 silver badges17 bronze badges

Collectives™ on Stack Overflow

HTML isn't working with javascript

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related