Java TreeMap iterator not working correctly for String keys

Question

I have a TreeMap that maps String keys to a custom City class. Here is how it is instantiated:

TreeMap<String, City> nameDictionary = new TreeMap<String, City>(new CityNameComparator());

CityNameComparator implementation:

    public class CityNameComparator implements Comparator<String>
{
    public int compare (String c1, String c2) {
        return c1.compareTo(c2);
    }
}

I have a method that returns an iterator that should iterate through the map in key-ascii order:

    public Iterator<City> getNameIterator(){
    return nameDictionary.values().iterator();
}

For some reason the values are returned in the order they were added to the TreeMap. Any ideas?

Can you post working code that replicates the problem? I don't see any obvious errors, though having a custom comparater that just uses the natural ordering of String anyway is kinda pointless. — Michael Borgwardt
– Michael Borgwardt, Commented Oct 4, 2009 at 19:00
I can't see any reason why this shouldn't work. It's always worked for me. — Paul Tomblin
– Paul Tomblin, Commented Oct 4, 2009 at 19:22

Kolibri · Accepted Answer · 2009-10-04 20:45:27Z

It works just fine:

import java.util.Comparator;
import java.util.Iterator;
import java.util.TreeMap;


public class test2 {

    public static class City {
        public final String m_name;

        public City(String aName) {
            m_name = aName;
        }
    }

    public static class CityNameComparator implements Comparator<String>
    {
        public int compare (String c1, String c2) {
            return c1.compareTo(c2);
        }
    }

    public static class CityMap {
        TreeMap<String, City> nameDictionary = new TreeMap<String, City>(new CityNameComparator());

        public Iterator<City> getNameIterator(){
            return nameDictionary.values().iterator();
        }

        public City put(String aName) {
            return nameDictionary.put(aName, new City(aName));
        }
    }

    public static void main(String[] args) {
        CityMap cityMap = new CityMap();
        cityMap.put("d");
        cityMap.put("b");
        cityMap.put("c");
        cityMap.put("a");

        for (Iterator<City> cities = cityMap.getNameIterator(); cities.hasNext(); ) {
            City city = cities.next();
            System.out.println(city.m_name);
        }
    }
}

Output:

a

b

c

d

erickson · Accepted Answer · 2009-10-04 19:25:22Z

0

Are you sure a LinkedHashMap hasn't been assigned to the Map reference by mistake? That would preserve the order the entries were added to the map.

Or perhaps there is a bug in the code that is adding entries, putting the wrong value with a key.

Iterate over the entries, and see what is in the map:

for (Map.Entry<String, City> e : dictionary.entrySet()) 
  System.out.println(e.getKey() + " --> " + e.getValue());

edited Oct 4, 2009 at 19:25

answered Oct 4, 2009 at 19:19

erickson

271k59 gold badges407 silver badges502 bronze badges

Comments

Jared · Accepted Answer · 2009-10-04 20:50:50Z

0

Sorry, stupid bug. I was assigning a different iterator based on a bug somewhere else. It works fine now.

answered Oct 4, 2009 at 20:50

Jared

2,1537 gold badges35 silver badges64 bronze badges

Collectives™ on Stack Overflow

Java TreeMap iterator not working correctly for String keys

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related