configure checkstyle to ignore an empty catch block

Question

in my team we use checkstyle to improve our coding standards, but now we came across a rule which could be improved.

The Empty Block rule gives us a warning about an empty catch block (without java code and without comment), but with the standard configuration it generates also a warning if the block contains a comment.

e.g.

The two should not result a warning:

try {
    // some code
} catch (NumberFormatException ignore) {
    // ignore
}

try {
    // some code
} catch (NumberFormatException e) {
    logger.debug("some debug");
}

This should result a warning:

try {
    // some code
} catch (NumberFormatException ignore) {

}

How can we improve checkstyle to give us only a warning, if no comment and no java code is in the catch block?

I looked for a solution, but I stackoverflow and google didn't have any.

Can someone help me?

stackoverflow.com/questions/4023185/…

Nikolay Kuznetsov
– Nikolay Kuznetsov

2013-03-19 13:52:38 +00:00
Commented Mar 19, 2013 at 13:52 — Nikolay Kuznetsov
– Nikolay Kuznetsov, Commented Mar 19, 2013 at 13:52

Community · Accepted Answer · 2017-05-23 10:29:45Z

5

The general question of how to tailor Checkstyle is ansered by this Question:

How to disable a particular checkstyle rule for a particular line of code?

The Checkstyle documentation for tailoring the checking of blocks is here:

http://checkstyle.sourceforge.net/config_blocks.html

And the specific style configuration you need is:

  <module name="EmptyBlock">
    <property name="option" value="text"/>
    <property name="tokens" value="LITERAL_CATCH"/>
  </module>

edited May 23, 2017 at 10:29

CommunityBot

11 silver badge

answered Mar 19, 2013 at 13:56

Stephen C

723k95 gold badges849 silver badges1.3k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Gabe Sechan Over a year ago

While this was true when answered, it is now EmptyCatchBlock as mentioned below.

Roman Ivanov · Accepted Answer · 2015-03-30 15:20:57Z

2

That problem was addressed at https://github.com/checkstyle/checkstyle/issues/571 , new Check was created - EmptyCatchBlock - http://checkstyle.sourceforge.net/config_blocks.html#EmptyCatchBlock

In configuration EmptyBlock , please remove CATCH token, as validation will done by different Check now

edited Mar 30, 2015 at 15:20

answered Mar 30, 2015 at 12:23

Roman Ivanov

2,5473 gold badges21 silver badges31 bronze badges

Collectives™ on Stack Overflow

configure checkstyle to ignore an empty catch block

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related