Why I can't call that function from inside 2 functions?

Question

This is my code:

inserisciMarker();

function scorriAllaLista(param) {
    alert(param);
}

function inserisciMarker() {
    markerClick = function () {
        $('#example').attr("onclick", "scorriAllaLista('hello'); return false;");
    };

    markerClick();
}

clicking on link, Uncaught ReferenceError: scorriAllaLista is not defined

Why? How can I fix it?

Most likely it isn't defined globally. window.scorriAllaLista = scorriAllaLista Why are you setting an onclick attribute with javascript rather than binding an event? — user400654
– user400654, Commented Mar 20, 2013 at 14:11
@both: I can't, for this unresolved problem: stackoverflow.com/questions/13033506/… — markzzz
– markzzz, Commented Mar 20, 2013 at 14:13
seems that google maps "remove" all handlers.. so I can't attach it! — markzzz
– markzzz, Commented Mar 20, 2013 at 14:14
It doesn't remove handlers, you're just miss-interpreting results. Events simply aren't bubbling because google maps stops them before they reach the body. (which was explained in your previous question) Bind the event using the google maps api. That's why they included that functionality after all. — user400654
– user400654, Commented Mar 20, 2013 at 14:25

Denys Séguret · Accepted Answer · 2013-03-20 14:11:56Z

10

That's not how you bind event handler using jQuery.

Replace

$('#example').attr("onclick", "scorriAllaLista('hello'); return false;");

with

$('#example').click(function(){
    scorriAllaLista('hello');
    return false;
});

answered Mar 20, 2013 at 14:11

Denys Séguret

384k90 gold badges813 silver badges780 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

Benjamin Gruenbaum Over a year ago

Correct answer, probably the simplest solution, !!/ninjad again :)

Andreas Grech Over a year ago

The return false is redundant in this case.

Denys Séguret Over a year ago

@AndreasGrech I don't see why. Returning false tells jQuery to both stop propagation of the event and to prevent default click behavior. Depending on OP's will, it may be useful.

Nope Over a year ago

@AndreasGrech: OP used return false in original code so the comment might be better on the original question directed at OP?

Denys Séguret Over a year ago

@markzzz your question isn't clear ? Are you trying to inject code in an iframe coming from another origin ?

|

Nope · Accepted Answer · 2013-03-20 14:26:14Z

2

If you realy must do it the way you do, you can add the method to the global window object, similar to this:

window.scorriAllaLista = function(param) {
    alert(param);
}

DEMO - add method to window

As you are already using return false you might get away with a href="#" as return false; already stops propagation as well as prevents default behaviour.

answered Mar 20, 2013 at 14:26

Nope

22.4k8 gold badges50 silver badges73 bronze badges

3 Comments

Denys Séguret Over a year ago

+1 because this solves OP's real problem (which is somewhat different from what was initially told). I tested a simple variation using a dynamic function (thus avoiding the param).

markzzz Over a year ago

But why I need to add function to the dom? the function should be visible inside functions.

Nope Over a year ago

@markzzz: I'm not 100% sure but it definetly has to do with the fact the method is called from within an onclick attribute. I don't know the intrinsics but the error message you got indicated the execution expected scorriAllaLista to be accessable on a global level. As dystroy' answer shows, using .click() will work without adding your method to window but you are not able to do that as you stated in your comments.

Collectives™ on Stack Overflow

Why I can't call that function from inside 2 functions?

2 Answers 2

10 Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

10 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related