Writing to file using values from an object in C#

Question

My objective with this code is to use the foreach loop to go through each object and write the current string value to a txt file.

I'm using "Woof" and "Bull" as a test. Bull is the string variable in my AverageValues class.

Unfortunately, it currently will not write the value of bull to the file, however, it will create the file.

I think this is something easy to fix, I'm just can't seem to find it right now.

All help would be appreciated!

    public void doStuff()
    {
        AverageValues AVS = new AverageValues();
        AVS.Bull = "Woof";
        string path = "C:\\users\\kjenks11\\Averages.txt";
        FileStream NewFile = File.Create(path);
        StreamWriter writeIt = new StreamWriter(NewFile);
        List<AverageValues> AV = new List<AverageValues>();
        AV.Add(AVS);

        foreach (var value in AV)
        {
                writeIt.Write(value.Bull);
        } 
        NewFile.Close();
     }

EJC · Accepted Answer · 2013-03-21 21:47:01Z

3

You need to flush to write the data to the file. You also might consider adding using statements to your writer to free the resources when you're done.

public void doStuff()
{
  AverageValues AVS = new AverageValues();
  AVS.Bull = "Woof";
  string path = "C:\\users\\kjenks11\\Averages.txt";
  using (var NewFile = File.Create(path))
  {
    using (var writeIt = new StreamWriter(NewFile))
    {
      List<AverageValues> AV = new List<AverageValues> {AVS};
      foreach (var value in AV)
      {
        writeIt.Write(value.Bull);
      }
    }
  }
}

edited Mar 21, 2013 at 21:47

answered Mar 21, 2013 at 21:40

EJC

2,1715 gold badges22 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Oded · Accepted Answer · 2013-03-21 21:47:14Z

3

Flush or close the stream before closing the file itself:

foreach (var value in AV)
{
     writeIt.WriteLine(value.Bull);
}
writeIt.Flush();
writeIt.Close();

Note on style - when creating a Stream (of any kind), or rather, any object that implements IDisposable, create it with a using statement:

using(var writeIt = new StreamWriter(NewFile))
{
  // use writeIt here - it will dispose properly
}

edited Mar 21, 2013 at 21:47

answered Mar 21, 2013 at 21:38

Oded

501k102 gold badges900 silver badges1k bronze badges

Comments

d.moncada · Accepted Answer · 2013-03-21 22:04:11Z

2

If you use using around your stream, there's no need to call flush and close explicitly. As soon as you leave the using block' scope the stream will be closed and disposed. The close will call flush for you.

  public void doStuff()
    {
        AverageValues AVS = new AverageValues();
        AVS.Bull = "Woof";
        string path = "C:\\users\\kjenks11\\Averages.txt";
        FileStream NewFile = File.Create(path);
        List<AverageValues> AV = new List<AverageValues>();
        AV.Add(AVS);

        using(StreamWriter writeIt = new StreamWriter(NewFile))
        {
           foreach (var value in AV)
           {
                writeIt.Write(value.Bull);
           } 
        }
       NewFile.Close();
    }

edited Mar 21, 2013 at 22:04

answered Mar 21, 2013 at 21:44

d.moncada

17.5k5 gold badges57 silver badges82 bronze badges

1 Comment

Infinite Possibilities Over a year ago

You can use using on the FileStream like @EJC post, but at minimim I'd move the NewFile.Close() to below the using block.

Collectives™ on Stack Overflow

Writing to file using values from an object in C#

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related