If statement fails even when the variables match

Question

I am trying to make a program that organizes punch-ins from an RFID scanner in google sheets...

When I go to match scan [i] with employee name [j] it never succeeds.

I have a simple if statement:

//names[i] is the name of the card for the scan event (card names = employee full name)
var name = names[i];

//the j for loop will check all employee names in the list for a match
var employee = employees[j];
if (name==employee) {
  var ifsuccess = true;
}

But I never get ifsuccess to = true... it may be obvious but I have never done programming in google script before (or javascript :P) does anyone know what I've done wrong?

screenshot

Maybe you are bitten by the javascript equality goodness: stackoverflow.com/questions/359494/… name === employee might do the trick — rene
– rene, Commented Mar 23, 2013 at 18:03
@rene If a == b never succeeds, what makes you think that a === b, a more specific conditional, would do any better? — Niet the Dark Absol
– Niet the Dark Absol, Commented Mar 23, 2013 at 18:07
@rene equality is always truthy - what's true for === will always be true for ==. — Barney
– Barney, Commented Mar 23, 2013 at 18:09

Matt Coughlin · Accepted Answer · 2013-03-23 18:06:36Z

1

It looks like you're comparing two Array objects rather than two strings. The screenshot claims that name and employee are indexed arrays with a single element.

To compare the string data inside each Array object:

name[0] == employee[0]     // equal value

Or the slightly safer:

name[0] === employee[0]    // equal value and of the same type

answered Mar 23, 2013 at 18:06

Matt Coughlin

18.9k3 gold badges48 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user2202843 Over a year ago

That seems to have done it!!! Thanks a million! Originally I had names[i] == employees [j]... why does the array[i] return another array?

Matt Coughlin Over a year ago

Because names and employees are arrays of arrays. Each array element in names and employees is an array with a single element (a string). In other words, they're arrays of arrays of strings, rather than arrays of strings, which you might typically expect.

Spencer Lockhart · Accepted Answer · 2013-03-23 18:06:44Z

0

> foo = ['foo'];
[ 'foo' ]
> bar = ['foo'];
[ 'foo' ]
> foo == bar
false
> foo === bar
false

Comparing array to array- even if they look the same, will not be true unless they are really referencing the same array in memory.

> bar = foo;
[ 'foo' ]
> foo == bar
true
> foo === bar
true

So, try comparing strings instead:

if (bar[0] === foo[0])

answered Mar 23, 2013 at 18:06

Spencer Lockhart

1,1747 silver badges7 bronze badges

Comments

guessimtoolate · Accepted Answer · 2013-03-23 18:10:36Z

0

Using toString method might help as well:

name.toString()==employee.toString()

But the other suggestions look cleaner.

answered Mar 23, 2013 at 18:10

guessimtoolate

8,6722 gold badges21 silver badges26 bronze badges

Comments

Bergi · Accepted Answer · 2013-03-23 18:11:13Z

0

In your debugger you can see that both name and employee refer to arrays with a string in it - yet those are two distinct arrays (with different internal ids), which are therefore not equal in terms of ==.

If you want to compare the strings inside them, use

var ifsuccess = name[0] == employee[0];

answered Mar 23, 2013 at 18:11

Bergi

671k162 gold badges1k silver badges1.5k bronze badges

Collectives™ on Stack Overflow

If statement fails even when the variables match

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related