ruby on rails instance variable and if elsif

Question

In my Show View I have:

  <div class="reviews" >
  <% @reviews.each do |review| %>
  <%= review_block review %>
  <% end %>
  </div>

In my Controller I have:

  def show    
  @review = Review.new
  @reviews = @user.reviews
  end

The idea is that if there are reviews that have been written, they are displayed on the page underneath the divs that currently exist- this part is working ok.

But if there are no reviews written, I just get nothing underneath the currently existing divs. How could I display some text like 'No reviews written, sorry!'

Ideally I'd like to show a partial, because I will be displaying more texts/ images.

I was working on something like this:

  <div class="reviews" >
  <% @reviews.each do |review| %>
  <%= review_block review if review>0 %>
  <%= else render :partial => 'layouts/no_reviews' %>
  <% end %>

But it's not working. Thanks for any help!

Chris

Michael Durrant · Accepted Answer · 2013-03-26 00:20:26Z

1

<div class="reviews" >
<% if @reviews && @reviews.present? %>
  <% @reviews.each do |review| %>
  <%= review_block review %>
<% end %>
<%= else render :partial => 'layouts/no_reviews' %>
<% end %>

e.g.

1.9.3-p327 :012 > if @abc
1.9.3-p327 :013?>   puts 'yes'
1.9.3-p327 :014?>   end
 => nil # We get noting
1.9.3-p327 :015 > @abc='lolololo'
 => "lolololo" 
1.9.3-p327 :016 > if @abc
1.9.3-p327 :017?>   puts 'yes'
1.9.3-p327 :018?>   end
yes # We get yes

edited Mar 26, 2013 at 0:20

answered Mar 25, 2013 at 19:46

Michael Durrant

97.2k102 gold badges352 silver badges536 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Marcelo De Polli Over a year ago

Wouldn't an empty array go through the if statement just like a non-empty array? You might want to use <% if @reviews && @reviews.present? %>

Sam · Accepted Answer · 2013-03-25 19:46:11Z

0

Try this,

<div class="reviews" >
  <% if @reviews.any? %>
    <% @reviews.each do |review| %>
      <%= review_block review %>
    <% end %>
  <% else %>
    <%= render :partial => 'layouts/no_reviews' %>
  <% end %>
</div>

answered Mar 25, 2013 at 19:46

Sam

3,06818 silver badges14 bronze badges

2 Comments

CHarris Over a year ago

Excellent! Works great. So easy when you see the code done out like that. Thanks also, Michael.

Michael Durrant Over a year ago

You are welcome :) Feel free to express your gratitude in the form of an up-vote (but only if you found the answer helpful).

Collectives™ on Stack Overflow

ruby on rails instance variable and if elsif

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related