Delete a row from gridview in back end c#

Question

I am trying to delete a gridview row in the back end. When I click delete it deletes from the gridview, however it does not delete from the database. Can anyone see why this may be? My code is as follows:

protected void GVMyBookings_DeleteBooking(object sender, GridViewDeleteEventArgs e)
{
     string connstring = ConfigurationManager.ConnectionStrings["BookingConn"].ToString();
     SqlConnection MyConnection = new SqlConnection(connstring);

     MyConnection.Open();

     SqlDataSource SDSBooking= new SqlDataSource();
     SDSBooking.DeleteCommand = "DELETE FROM Tbl_Booking WHERE BookingID_PK = @BookingID_PK";
     SDSBooking.DeleteParameters.Add("@BookingID_PK", GVMyBookings.Rows[e.RowIndex].Cells[0].ToString());
     SDSBooking.ConnectionString = connstring;

     GVMyBookings.DataSource = SDSBooking;
     GVMyBookings.DataBind();
     MyConnection.Close();
}

The gridview is:

<asp:GridView ID="GVMyBookings" runat="server" GridLines="Vertical" AllowSorting="True"
    AutoGenerateColumns="False" AutoGenerateDeleteButton="true" 
    OnRowDeleting="GVMyBookings_DeleteBooking" EmptyDataText="You have no upcoming bookings" >
    <RowStyle BackColor="#e5ecbf" />
    <Columns>
        <asp:BoundField DataField="BookingID_PK"  />
        <asp:BoundField DataField="BookingDate" HeaderText="Booking Date" 
            SortExpression="BookingDate" DataFormatString="{0:d}" />
        <asp:BoundField DataField="RoomName" HeaderText="Room Name" 
            SortExpression="RoomName" />
        <asp:BoundField DataField="StartTime" HeaderText="Start Time" 
            SortExpression="StartTime"/>
        <asp:BoundField DataField="EndTime" HeaderText="End Time" 
            SortExpression="EndTime" />
        <asp:BoundField DataField="StaffUID" HeaderText="StaffUID" 
            SortExpression="StaffUID" Visible="false" />
    </Columns>
    <HeaderStyle BackColor="#264409" Font-Bold="True" ForeColor="White" />
    <AlternatingRowStyle BackColor="White" />
</asp:GridView>

anouar.bagari · Accepted Answer · 2013-04-07 17:32:53Z

2

Seems that your query is incorrect

DELETE * FROM Tbl_Booking WHERE ID=@BookingID_PK

Use this instead

DELETE FROM Tbl_Booking WHERE ID=@BookingID_PK

Remove the @ symbole from this line

SDSBooking.DeleteParameters.Add("BookingID_PK",...);

Then call Delete explicitly against the dataSource

... 
SDSStudents.ConnectionString = connstring;
SDSStudents.Delete();
GridView1.DataSource = SDSStudents;  
...

edited Apr 7, 2013 at 17:32

answered Apr 6, 2013 at 21:46

anouar.bagari

2,10419 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Claire Over a year ago

An error occured on the SDSBooking.Delete() saying: Conversion failed when converting the nvarchar value 'System.Web.UI.WebControls.GridViewRow' to data type int

anouar.bagari Over a year ago

@Claire Try to replace this GVMyBookings.Rows[e.RowIndex].Cells[0].ToString() by GridView1.Rows[e.RowIndex].Cells[0].Text

Claire Over a year ago

No error, it deletes from the gridview, but then when I refresh the page it is there again - so it still isn't updating the database. Is this all in the correct order?: SqlDataSource SDSBooking = new SqlDataSource(); SDSBooking.ConnectionString = connstring; SDSBooking.Delete(); SDSBooking.DeleteCommand = "DELETE FROM Tbl_Booking WHERE BookingID_PK = @BookingID_PK"; SDSBooking.DeleteParameters.Add("BookingID_PK", GVMyBookings.Rows[e.RowIndex].Cells[0].Text); GVMyBookings.DataSource = SDSBooking; GVMyBookings.DataBind(); MyConnection.Close();

anouar.bagari Over a year ago

@Claire SDSBooking.Delete(); and SDSBooking.DeleteCommand = "DELETE FROM Tbl_Booking WHERE BookingID_PK = @BookingID_PK"; are reversed

Devraj Gadhavi · Accepted Answer · 2013-04-08 06:18:55Z

Your code sequence to delete the record from database should be like this.

//Declaring the datasource.
SqlDataSource SDSBooking= new SqlDataSource();

//Providing the delete command.
SDSBooking.DeleteCommand = "DELETE FROM Tbl_Booking WHERE BookingID_PK = @BookingID_PK";

//Adding the parameter for deleting the record.
SDSBooking.DeleteParameters.Add("BookingID_PK", GVMyBookings.Rows[e.RowIndex].Cells[1].Text);

//Providing the connection string.
SDSBooking.ConnectionString = connstring;

//Executing the delete method of the SqlDataSouce. 
//It is this line that will actually delete your record.
SDSBooking.Delete();

After this you can assign this datasource to you gridview.

Note : For GVMyBookings.Rows[e.RowIndex].Cells[1].Text, you need to make sure, that your databound field is at index 1 in the TableCellCollection.

You might need to change, if you are generating some other columns before it.

As because in your case the delete button would be generated before your databound field. So the delete button would be at index 0 & your databound field *BookingID_PK* would be at index 1.

Collectives™ on Stack Overflow

Delete a row from gridview in back end c#

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related