Returning an Array in a Method

Question

I have a method that will return a String[], depending on previous user input that will determine if the parameter is "INTERNATIONAL" or "DOMESTIC". Regardless, both inputs should lead to the creation of two different String[]. When I try to compile though, I get an "missing return statement" error message. How can I fix this?

Here is my method:

   public String[] typeflight(String type)
     { 
        String type2= type.toUpperCase();
        if (type2.equals("INTERNATIONAL"))
        {
            String[] flights = {"B738 to Melbourne, Australia ", "A380 to Beijing, China ", "F348 to London, England ", "M225 to Ontario, Canada",
                    "E987 to Tokyo, Japan ", "T451 to Copenhagen, Denmark ", "S501 to Seoul, South Korea ", "N778 to Venice, Italy ",
                    "B621 to Mexico City, Mexico ", "L454 to Rabat, Morocco ", "C998 to San Jose, Costa Rica", "H859 to Amsterdam, Netherlands "};
            return flights;

        }
        else
        if(type2.equals("DOMESTIC"))
        {   
            String[] flights = {"459 to Seattle, Washington ", "662 to Los Angeles, California ", "712 to New Orleans, Louisiana ", "285 to Chicago, Illinois ",
                    "896 to Honolulu, Hawaii ", "476 to Boston, Massachusetts ", "823 to Newark, New Jersey ", "902 to Miami, Florida ",
                    "353 to Fort Wayne, Indiana ", "112 to Des Moines, Iowa ", "", "294 to Las Vegas, Nevada"};
            return flights;

        }
    }

Thanks in advance!

What happens if type is neither INTERNATIONAL nor DOMESTIC and your method is invoked? — Muel
– Muel, Commented Apr 11, 2013 at 3:50
@Muel I didn't see that problem before, but I understand now and I fixed it. Thanks! — nichi
– nichi, Commented Apr 11, 2013 at 3:57

tskuzzy · Accepted Answer · 2013-04-11 03:50:34Z

4

What happens if neither of those if-statements is true? Then your method has no return value.

e.g. type2 = "ALIEN"

Perhaps there is logic in your program that prevents this from happening. But the Java compiler does not know this.

A quick and dirty fix for this is to just put a return null; at the end of the method. A "better" way is to use exceptions for illegal arguments.

answered Apr 11, 2013 at 3:50

tskuzzy

36.6k15 gold badges78 silver badges145 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

nichi Over a year ago

I see the problem now! Thank you very much:)

Amarnath · Accepted Answer · 2013-04-11 03:52:25Z

2

If both the if conditions fails the function is not returning anything. So return null if both the conditions don't match.

public String[] typeflight(String type)
 { 
    String type2= type.toUpperCase();
    if (type2.equals("INTERNATIONAL"))
    {
        // Code
        return flights;

    }
    else
    if(type2.equals("DOMESTIC"))
    {   
        // Code 
        return flights;

    }

    return null;
}

answered Apr 11, 2013 at 3:52

Amarnath

8,89510 gold badges58 silver badges85 bronze badges

Comments

Sajjan Singh · Accepted Answer · 2013-04-11 03:51:03Z

0

Your issue is that you have an if and and else if, but no else. Java is complaining that the case where type2 does not equal either of the two given values is not addressed.

answered Apr 11, 2013 at 3:51

Sajjan Singh

2,5612 gold badges28 silver badges35 bronze badges

Comments

cat916 · Accepted Answer · 2013-04-11 03:51:51Z

0

Well compiler need an outside "return statement" to determine return results.

answered Apr 11, 2013 at 3:51

cat916

1,37110 silver badges18 bronze badges

Comments

thar45 · Accepted Answer · 2013-04-11 03:54:30Z

0

You should have the return statement for all the cases . So declare the String flights out side the if else and initailize dynmically, and finally return as

 public String[] typeflight(String type)
    {
    String[] flights;
         if(condition1){
           flights  = ....
           }
         else{
            flights = .....   
      }
          return flights;
    }

Also you should avoid the declaration of data members in the same name ,

answered Apr 11, 2013 at 3:54

thar45

3,5705 gold badges35 silver badges49 bronze badges

Collectives™ on Stack Overflow

Returning an Array in a Method

5 Answers 5

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related