How can I pass back a promise from a service in AngularJS?

Question

I have some code in my controller that was directly calling $http to get data. Now I would like to move this into a service. Here is what I have so far:

My service:

angular.module('adminApp', [])
.factory('TestAccount', function ($http) {
    var TestAccount = {};
    TestAccount.get = function (applicationId, callback) {
        $http({
            method: 'GET',
            url: '/api/TestAccounts/GetSelect',
            params: { applicationId: applicationId }
        }).success(function (result) {
            callback(result);
        });
    };
    return TestAccount;
});

Inside the controller:

   TestAccount.get(3, function (data) {
      $scope.testAccounts = data;
   })

How can I change this so rather than passing the result of success back it passes back a promise that I can check to see if it succeeded or failed?

$http itself returns a promise so can use all the methods from $q promise API on it, or use error callback — charlietfl
– charlietfl, Commented Apr 14, 2013 at 16:57

pkozlowski.opensource · Accepted Answer · 2013-04-14 17:20:07Z

3

Make your service to return a promise and expose it to service clients. Change your service like so:

angular.module('adminApp', [])
.factory('TestAccount', function ($http) {
    var TestAccount = {};
    TestAccount.get = function (applicationId) {
        return $http({
            method: 'GET',
            url: '/api/TestAccounts/GetSelect',
            params: { applicationId: applicationId }
        });
    };
    return TestAccount;
});

so in a controller you can do:

TestAccount.get(3).then(function(result) {
   $scope.testAccounts = result.data;
}, function (result) {
    //error callback here...  
});

answered Apr 14, 2013 at 17:20

pkozlowski.opensource

117k60 gold badges329 silver badges286 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How can I pass back a promise from a service in AngularJS?

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related