Popup window in Javascript

Question

In Javascript, I want to open my window.html file in a popup window. But it doesn't display any text. Just a blank page.

This is index.html:

<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" type="text/css" href="style.css" />

  <script language="javascript">
    var newwindow;

    function popit(url){
      newwindow = window.open(
          url, '', "status=yes, height=500; width=500; resizeable=0");
  }
  </script>
</head>
<body>
  <a href="javascript:popit(window.html);">CLICK ME!</a>
</body>
</html>

window.html:

<!DOCTYPE html>
<html>
<head>
</head>
<body>
    <p>SAMPLE TEXT</p>
</body>
</html>

Why doesn't it display any text?

A lot of browser block popups...

tur11ng
– tur11ng

2017-03-13 21:58:01 +00:00
Commented Mar 13, 2017 at 21:58 — tur11ng
– tur11ng, Commented Mar 13, 2017 at 21:58

BestDeveloper · Accepted Answer · 2013-04-28 14:42:05Z

2

javascript:popit(window.html);

Replace with:

javascript:popit('window.html');

answered Apr 28, 2013 at 14:42

BestDeveloper

3431 gold badge5 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pointy · Accepted Answer · 2013-04-28 14:40:40Z

0

Your click handler code is syntactically incorrect:

<a href="#" onclick="popit('window.html');">CLICK ME!</a>

Always, always have your developer console open to check for JavaScript errors! (edit — actually in this case there wouldn't have been an error; window.html would resolve to undefined probably! Still, keep the console open :-)

Also note that I used an "onclick" attribute instead of "href".

answered Apr 28, 2013 at 14:40

Pointy

415k62 gold badges600 silver badges631 bronze badges

Comments

SeekLoad · Accepted Answer · 2017-03-13 21:52:19Z

A GOOD working code with NO crashes.

Simple and what makes this code better is that you can use it in a JavaScript file separately and have it fairing to more then one file with the same popup size even though its different pages on popups.

Javascript

// Popup window code
function MyPopUp(url) {
    popupWindow = window.open(
        url,'popUpWindow','height=454,width=580,left=0,top=200,resizable=yes,scrollbars=yes,toolbar=yes,menubar=no,location=no,directories=no,status=yes')
}

HTML

<a href="JavaScript:MyPopUp('MyDirectory/Page.html');" title="My PopUp For You">My PopUp</a>

NOTE: You can also use this as onload in body for example <body onload="JavaScript:MyPopUp('MyDirectory/Page.html');"> and it will aslo work on onmouseover and others... though I do not advise this unless you want to piss off the clients visiting your page.

Collectives™ on Stack Overflow

Popup window in Javascript

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related