How do I split two strings and make a key-value pair in javascript

Question

var ma = "jim";     
var nu = "123";    
var splitit = ma.split("");    
var splitit2 = nu.split("");    
for (i=0; i<=splitit.length;i++) {
    var bach = {splitit[i]:splitit2[i]};
}
alert(bach);

possible duplicate of Dynamic variable in javascript push function — Denys Séguret
– Denys Séguret, Commented May 7, 2013 at 12:07
Initializing variables inside of the for loop is not a good strategy for performance. It is better to cache it outside the loop and make reference to it. Please note. — gmajivu
– gmajivu, Commented May 7, 2013 at 12:10
@gabeno I don't see why they could be a difference (variable declarations are hoisted) and tests don't support your thesis either : jsperf.com/var-in-for-or-not — Denys Séguret
– Denys Séguret, Commented May 7, 2013 at 12:14

Denys Séguret · Accepted Answer · 2013-05-07 12:05:32Z

1

You probably want

var bach = {}; // create the object
for (i=0; i<=splitit.length;i++) {
    bach[splitit[i]]=splitit2[i]; // set a property according to the arrays
}

instead of

for (i=0; i<=splitit.length;i++) {
    var bach = {splitit[i]:splitit2[i]};
}

answered May 7, 2013 at 12:05

community wiki

Denys Séguret

Sign up to request clarification or add additional context in comments.

Comments

Arun P Johny · Accepted Answer · 2013-05-07 12:05:47Z

0

Use

var ma = "jim";     
var nu = "123";    
var splitit = ma.split("");    
var splitit2 = nu.split("");    
var bach = {};
for (i=0; i<=splitit.length;i++) {
    bach[splitit[i]] =splitit2[i];
}

Demo: Fiddle

answered May 7, 2013 at 12:05

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

Comments

Bergi · Accepted Answer · 2013-05-07 12:06:27Z

0

You cannot use variables for property names in object literals, they always get interpreted literally. And you probably want only one bach object, instead of creating a new one each loop turn.

var bach = {};
for (i=0; i<=splitit.length;i++) {
    bach[splitit[i]] = splitit2[i];
}
alert(JSON.stringify(bach));

answered May 7, 2013 at 12:06

Bergi

671k162 gold badges1k silver badges1.5k bronze badges

Collectives™ on Stack Overflow

How do I split two strings and make a key-value pair in javascript

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related