Rails - paperclip - Multiple photo upload not saving

Question

I'm trying to make a create product page in rails. This includes adding multiple images and text fields. I have one model for products and one for photos. I'm using the paperclip gem for photo upload. But I get no picture when I view product page. Photos are not being saved to database.

P.S. I use HAML.

app/views/products/show.html.haml

  %b Name
  = @product.name
  %br

  %b Description
  = @product.description

  %br
  - @product.photos.each do |photo|
  = image_tag photo.image.url

app/controllers/products_controller

class ProductsController < ApplicationController
  before_filter :require_login
    before_filter :current_user, only: [:create, :destory]

  def new 
    @product = Product.new
    @photo = Photo.new
    5.times { @product.photos.build }
  end

  def create

  @photo = current_user.photos.build(params[:photo])
  @product = current_user.products.build(params[:product])
    if @product.save
        render "show", :notice => "Sale created!"
    else
        render "new", :notice => "Somehting went wrong!"
    end
end

  def show
    @product = Product.find(params[:id]) 
  end

app/models/photo

class Photo < ActiveRecord::Base
  attr_accessible :product_id    
  belongs_to :product
  has_attached_file :image,
    :styles => {
      :thumb=> "100x100#",
      :small  => "300x300>",
      :large => "600x600>"
        }
end

app/models/product

class Product < ActiveRecord::Base
  attr_accessible :description, :name, :price, :condition, :ship_method, :ship_price, :quantity, :photo
  has_many :photos, dependent: :destroy
  accepts_nested_attributes_for :photos
  belongs_to :user
end

user model

   class User < ActiveRecord::Base
      attr_accessible :email, :password, :password_confirmation, :name

      attr_accessor :password
      has_many :products, dependent: :destroy
      has_many :photos,:through=>:products

app/products/new.html.haml

= form_for @product, :html => { :multipart => true } do |f|
  %p
    = fields_for :photos do |f_i|
      =f_i.file_field :image

remove this line has_attached_file :photo from your Product model there is no need of it here. — Taimoor Changaiz
– Taimoor Changaiz, Commented May 23, 2013 at 7:39
i don't understood so far why you are asking same question again... What about old one? you are wasting others time.. stackoverflow.com/questions/16665809/… — Muhammad Sannan Khalid
– Muhammad Sannan Khalid, Commented May 30, 2013 at 8:41
and third one is here stackoverflow.com/questions/16807112/… — Muhammad Sannan Khalid
– Muhammad Sannan Khalid, Commented May 30, 2013 at 8:47

Huascar Ernesto Mamani · Accepted Answer · 2013-05-11 19:38:19Z

3

First your form is wrong, q for registration of photos used fields_for, then you use fields_for f.object.photos or use Photo.new do | g |, the other in your relationship model is wrong has_attached_file is has_many photos, the has_attached_file Paperclip is proper to be used in the model to be used not in the relationship with the other model. Hope this helps, now to have a product with several photographs, I recommend you use the gem cocoon, I q goes according to your case, https://github.com/nathanvda/cocoon

answered May 11, 2013 at 19:38

Huascar Ernesto Mamani

311 bronze badge

Sign up to request clarification or add additional context in comments.

1 Comment

Alain Goldman Over a year ago

This is not articulate enough

Muhammad Sannan Khalid · Accepted Answer · 2013-05-24 10:15:20Z

3

+50

You had written under Photo model as:

has_many :photos, :through => :products

This doesn't make any sense.. in your Photo model write

belongs_to :product

while in Product model write:

has_many :photos

actually this will be one-to-many relation as far i had understood:

There is no need to write has_attached_file in product model. This will be written under photo model like

has_attached_file :image

Now you have multiple photos for product. So you need loop for showing those photos. e.g., in your show view do some thing

<% unless @product.photos.blank? %>
  <% @product.photos.each do |photo| %>
    <%= image_tag photo.image.url %>
  <% end %>
<% end %>

_______ EDIT 2 ________

in your Product model

has_many :photos, :dependent => :destroy
accepts_nested_attributes_for :photos, :allow_destroy => true
attr_accessible :photos_attributes

in your photo model

belongs_to :product
attr_accessible :product_id

in your products controller

def new 
  @product = Product.new
  5.times { @product.photos.build }
end

def create
  @product = Product.new(params[:product])
  @product.user_id = current_user.id
  if @product.save
      render "show", :notice => "Sale created!"
  else
      render "new", :notice => "Somehting went wrong!"
  end
end

in your new.html.haml

= form_for @product, :html => { :multipart => true } do |f|
  - if @product.errors.any?
    .error_messages
      %h2 Form is invalid
      %ul
        - for message in @product.errors.full_messages
          %li
            = message
  %p
    = f.fields_for :photos do |f_i|
      =f_i.file_field :image

try out now. !

edited May 24, 2013 at 10:15

answered May 22, 2013 at 12:13

Muhammad Sannan Khalid

3,1371 gold badge24 silver badges38 bronze badges

2 Comments

Alain Goldman Over a year ago

huh ... thats weird they are not

Alain Goldman Over a year ago

any ideas on what i should do

Taimoor Changaiz · Accepted Answer · 2013-05-23 07:37:40Z

1

After looking at your code. Its quite straight forward that Product don't have any image attribute at all. Photo have image attribute.

So you have to access Products -> photos -> images

Do this in controller show action

@product = Product.find(id)
@photos = @product.photos

In show.html.erb

[email protected] do |photo|
= image_tag photo.image.url
-end

For haml syntax my applogies as these days working on project using html.erb. SO correct haml syntax if there is any error.

answered May 23, 2013 at 7:37

Taimoor Changaiz

10.7k4 gold badges52 silver badges55 bronze badges

Comments

Kiattisak Anoochitarom · Accepted Answer · 2013-05-12 04:33:10Z

-1

I think

5.times { @product.photos.build }

should be in #new method cuz .build method interact with @fields_for

answered May 12, 2013 at 4:33

Kiattisak Anoochitarom

2,1571 gold badge20 silver badges15 bronze badges

1 Comment

Muhammad Sannan Khalid Over a year ago

His relationship between models messed up.

Harish Malik · Accepted Answer · 2013-05-22 09:20:55Z

-1

   @product.image requires image to be the attribute of product model means image fields should be in products table.

   @product.image should be @product.photo.image.url

answered May 22, 2013 at 9:20

Harish Malik

892 bronze badges

2 Comments

Alain Goldman Over a year ago

Didn't work i end up getting undefined method `photos' for nil:NilClass

Muhammad Sannan Khalid Over a year ago

there are multiple photos for product.. @product.photo will not work, i guess need a loop for displaying all photos!

Collectives™ on Stack Overflow

Rails - paperclip - Multiple photo upload not saving

5 Answers 5

1 Comment

2 Comments

Comments

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

2 Comments

Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related