Angular: Why is my event handled twice?

Question

I have three controllers: main, product, customer. Controller A is part of my 'masterpage'. Controllers B and C are location dependent.

Controller main:

var MainController = function ($scope, $location, $rootScope, ToolbarService) {
    $scope.addClicked = function () {
        ToolbarService.onAddButtonClick();
    };
};

app.controller({ MainController: MainController });

product:

var ProductController = function ($scope) {

    $scope.$on('handleAddButtonClick', function () {
        alert('Add product');
    });
};
app.controller({ ProductController: ProductController });

customer:

var CustomerController = function ($scope) {

    $scope.$on('handleAddButtonClick', function () {
        alert('Add customer');
    });
};
app.controller({ CustomerController: CustomerController});

toolbarService:

app.service({
    ToolbarService: function ($rootScope) {
        return {
            onAddButtonClick: function () {
                $rootScope.$broadcast('handleAddButtonClick');
            }
        };
    }
});

When my location is #/products and the addClicked of main is invoked, I get the alert 'Add product' twice. Does anybody has a clue why this is?

are you sure you don't have two ng-controller="ProductController" in your page? Can you post the HTML? — Dan
– Dan, Commented May 16, 2013 at 13:21
@sh0ber Yes I am sure. When I search for ng-controller="ProductController" I get only one result.. — Martijn
– Martijn, Commented May 16, 2013 at 14:05
When I set up your functions in a fiddle with my HTML, everything works as expected, so I think somehow you are getting two instances of the controller. Maybe that happens elsewhere in your code if not your HTML — Dan
– Dan, Commented May 16, 2013 at 14:08

Martijn · Accepted Answer · 2013-06-14 08:24:11Z

30

The problem was that I also had a controller declared in the routes. So I had configured a controller on my html page and one in the routes provider. This caused that everything executed twice..

answered Jun 14, 2013 at 8:24

Martijn

24.9k62 gold badges181 silver badges270 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Northstrider Over a year ago

doh, i had this problem

brazorf Over a year ago

This helped me too, thank you. Hint: always be careful when declaring event handlers on object that may have multiple instances running at the same time.

Collectives™ on Stack Overflow

Angular: Why is my event handled twice?

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related