Python error: unhashable type: 'list'

Question

I started learning Python few weeks ago (with no previous knowledge of it nor programming). I want to create a definition which will for given dictionary as an argument return a tuple consisted of two lists - one where there are only keys of dictionary, and the other where there are only values of the given dictionary. Basically the code will look like this:

"""Iterate over the dictionary named letters, and populate the two lists so that 
keys contains all the keys of the dictionary, and values contains 
all the corresponding values of the dictionary. Return this as a tuple in the end."""

def run(dict):
    keys = []
    values = []
    for key in dict.keys():
        keys.append(key)
    for value in dict.values():
        values.append(value)
    return (keys, values)


print run({"a": 1, "b": 2, "c": 3, "d": 4})

This code worked perfectly (it's not my solution though). But what if I do not want to use the .keys() and .values() methods? In that case, I tried using something like this, but I got "unhashable type: 'list'" error message:

def run(dict):
    keys = []
    values = []
    for key in dict:
        keys.append(key)
        values.append(dict[keys])
    return (keys, values)


print run({"a": 1, "b": 2, "c": 3, "d": 4})

What seems to be the problem?

Martijn Pieters · Accepted Answer · 2013-05-28 23:59:38Z

6

You are trying to use the whole keys list as a key:

values.append(dict[keys])

Perhaps you meant to use dict[key] instead? A list is a mutable type, and cannot be used as a key in a dictionary (it could change in-place making the key no longer locatable in the internal hash table of the dictionary).

Alternatively, loop over the .items() sequence:

for key, value in dct.items():
    keys.append(key)
    values.append(value)

Please don't use dict as a variable name; you are shadowing the built-in type by doing that.

answered May 28, 2013 at 23:59

Martijn Pieters

1.1m326 gold badges4.2k silver badges3.4k bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

stgeorge Over a year ago

Thank you for such a quick reply Martijn. So it was my typo (Yes I need the "key" instead of "keys")? The solution works?

Martijn Pieters Over a year ago

@stgeorge: Yes, with values.append(dict[key]) you are adding dictionary values to the list. :-)

stgeorge Over a year ago

Thank you once again. You made my day! Or that is - night :)

John La Rooy · Accepted Answer · 2013-05-29 00:20:24Z

4

Another simpler (less chance for bugs) way to write your function

def run(my_dict):
    return zip(*my_dict.items())

answered May 29, 2013 at 0:20

John La Rooy

306k54 gold badges378 silver badges514 bronze badges

Comments

John La Rooy · Accepted Answer · 2013-05-29 00:26:01Z

2

Martijn's answer is correct but also note that your original sample does more work than it needs to. dict.keys() and dict.values() both return lists and there is no reason to recreate them. The code could be:

def run(my_dict):
    return my_dict.keys(), my_dict.values()

print run({"a": 1, "b": 2, "c": 3, "d": 4})

edited May 29, 2013 at 0:26

John La Rooy

306k54 gold badges378 silver badges514 bronze badges

answered May 29, 2013 at 0:12

tdelaney

77.9k6 gold badges91 silver badges129 bronze badges

2 Comments

stgeorge Over a year ago

Thank you for the reply tdelaney. For not I am just learning the Python, so it is far more important for me to understand the code, than to deal with it's speed or if I am doing something too "hard". By the way, why isn't there a return in your code?

John La Rooy Over a year ago

@stgeorge, there should be a return

Collectives™ on Stack Overflow

Python error: unhashable type: 'list'

3 Answers 3

3 Comments

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related