Retrieving data through mysql using function and use in the select box?

Question

i write a program to retrieve the data through MySQL using function now i have a problem that how i use it in the select box?

Code for this is given below,

function selectdata(){
$select="SELECT * FROM table_name";

$run=mysql_query($select);

while($fetch=mysql_fetch_array($run)){
 $field_name.=$fetch['field_name'];


}
return $field_name;
}

HTML:

<select name="office_name">

<option value=""><?php echo selectdata(); ?></option>

</select>

it is showing all the data in one field

any help??

What are you expecting to happen? Did you want a new <option> element for each row from the table? — Pudge601
– Pudge601, Commented Jun 5, 2013 at 10:29
Don't use mysql_ extensions it's deprecated, use PDO or msqli_ instead. — 6339
– 6339, Commented Jun 5, 2013 at 10:41

Yogesh Suthar · Accepted Answer · 2013-06-05 10:28:46Z

2

Do like this

function selectdata(){
   $select="SELECT * FROM table_name";

   $run=mysql_query($select);
   $field_name = '';
   while($fetch=mysql_fetch_array($run)){
       $field_name.="<option value=''>" . $fetch['field_name'] . "</option>";
   }
   return $field_name;
}

And in html

<select name="office_name">
<?php echo selectdata(); ?>
</select>

answered Jun 5, 2013 at 10:28

Yogesh Suthar

30.5k18 gold badges75 silver badges100 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Prisoner · Accepted Answer · 2013-06-05 10:29:09Z

2

That's because you're echoing your string into one option value. A better way would be to return an array from selectdata() and then loop through it in your html like:

function selectdata(){
    $select="SELECT * FROM table_name";

    $run=mysql_query($select);
    $fields = array()
    while($fetch=mysql_fetch_array($run)){
        $fields[] = $fetch['field_name'];
    }
    return $fields;
}

And then

<select name="office_name">
    <?php foreach(selectdata() as $option): ?>
    <option value="<?php echo $option; ?>"><?php echo $option; ?></option>
    <?php endforeach; ?>
</select>

This way, you're keeping HTML out of your PHP.

answered Jun 5, 2013 at 10:29

Prisoner

27.7k11 gold badges78 silver badges104 bronze badges

2 Comments

Hugo Delsing Over a year ago

Why would you want to do a loop twice? If you are already going trough all the rows, why not use it.

Prisoner Over a year ago

It allows you to reuse the selectdata function elsewhere as it wouldn't contain the HTML. Example: Once the user submits their form data you want to validate that it's one of the allowed options. You could then do in_array($_POST['office_name'], selectdata()). It's all about reusability and keeping HTML away from your PHP.

Jerin K Alexander · Accepted Answer · 2013-06-05 10:29:24Z

2

Try this one..Not sure the syntax is correct.

function selectdata(){
$select="SELECT * FROM table_name";

$run=mysql_query($select);

while($fetch=mysql_fetch_array($run)){
 $field_name.= "<option value=>" .$fetch['field_name']."</option>";
}
return $field_name;
}

HTML:

<select name="office_name">
<?php echo selectdata(); ?>
</select>

answered Jun 5, 2013 at 10:29

Jerin K Alexander

3016 silver badges17 bronze badges

1 Comment

ferdynator Over a year ago

you are missing the parenthesis for the value-Attribute as well as its content.

Dushyant Joshi · Accepted Answer · 2013-06-05 10:29:23Z

0

<?php
$query = mysql_query("YOUR QUERY HERE"); // Run your query

echo '<select name="DROP DOWN NAME">'; // Open your drop down box

// Loop through the query results, outputing the options one by one
while ($row = mysql_fetch_array($query)) {
   echo '<option value="'.$row['something'].'">'.$row['something'].'</option>';
}

echo '</select>';// Close your drop down box





?>

answered Jun 5, 2013 at 10:29

Dushyant Joshi

3,7223 gold badges32 silver badges54 bronze badges

Comments

ferdynator · Accepted Answer · 2013-06-05 10:37:13Z

0

You can use as following sample,

<?php
$sql = "SELECT * FROM terms";
$result = mysql_query($sql) or die(mysql_error());

while ($row = mysql_fetch_array($result,MYSQL_ASSOC)) {
   $term[$row{'term_id'}] = $row{'term_name'};
}
?>
    <select id="mass_term"  name="mass_term" style="width:125px;" >
   <?php foreach($term as $key=>$value){ ?>
      <option <?php echo ($key==$termid)?'selected="selected"':'' ?> value="<?php echo $key; ?>"><?php echo $value; ?></option>
   <?php } ?>
    </select>

edited Jun 5, 2013 at 10:37

ferdynator

6,4083 gold badges31 silver badges57 bronze badges

answered Jun 5, 2013 at 10:31

Mansoor Jafar

1,5183 gold badges15 silver badges32 bronze badges

Collectives™ on Stack Overflow

Retrieving data through mysql using function and use in the select box?

5 Answers 5

Comments

2 Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

2 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related