javascript input field onchange causes "is not a function"

Question

I have a function i would like to run onChange. This works fine with an a-tag. But when i use it on an input-tag it just says:

form.saveFile is not a function

This works:

<a onclick="form.saveFile('fec056b774ffefa479c7dd3a632275cb','fec056b774ffefa479c7dd3a632275cb_filetest'); return false;" href="#">Upload file</a>

This does NOT work:

<input onchange="form.saveFile('fec056b774ffefa479c7dd3a632275cb','fec056b774ffefa479c7dd3a632275cb_filetest');" id="fec056b774ffefa479c7dd3a632275cb_filetest" class="file" type="file"  name="fec056b774ffefa479c7dd3a632275cb_filetest" accesskey="F"/>

Both calls the same form.saveFile(); function.

The form variable is declared in a included js file like this:

form = {
  version: '1.0.0',
  ...alot of functions... 
  saveFile : function(callback,p){
    .................
  }
}

Where does the form variable come from? Where did you declare it? — Darin Dimitrov
– Darin Dimitrov, Commented Nov 8, 2009 at 10:12
Please post a minimal snipped of html + javascript code that reproduces the problem (both the working a onclick and the non-working input onchange). — Gerald Senarclens de Grancy
– Gerald Senarclens de Grancy, Commented Nov 8, 2009 at 10:18
I did post 2 html snippets. One working and one not working. a onclick works. but input onchange says the function is undefined. — jonaz
– jonaz, Commented Nov 8, 2009 at 10:20

Darin Dimitrov · Accepted Answer · 2009-11-08 10:26:10Z

3

form is a reserved word in a onchange handler. Just rename your variable and it will work:

var frm = {
    version: '1.0.0',
    saveFile : function(callback,p){
    }
};

<input onchange="frm.saveFile('fec056b774ffefa479c7dd3a632275cb','fec056b774ffefa479c7dd3a632275cb_filetest');" id="fec056b774ffefa479c7dd3a632275cb_filetest" class="file" type="file"  name="fec056b774ffefa479c7dd3a632275cb_filetest" accesskey="F"/>

answered Nov 8, 2009 at 10:26

Darin Dimitrov

1.0m276 gold badges3.3k silver badges3k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Gumbo · Accepted Answer · 2009-11-08 10:23:59Z

1

Inside forms form does refer to that specific form element. So you need to distinguish between the form that’s referring to the form element and your form variable. You can do so with using window.form if you defined your form variable in the global scope. Or you just rename it.

answered Nov 8, 2009 at 10:23

Gumbo

657k112 gold badges792 silver badges852 bronze badges

Comments

Senthil Kumar · Accepted Answer · 2009-11-08 10:20:55Z

0

need more info. did you try in all browsers? it should work. If the text has been changed, once the focus leaves the text box onchange will occur. try using alert() to test if the function is really called. there could be something wrong with your function. hope this helps.

answered Nov 8, 2009 at 10:20

Senthil Kumar

10.4k8 gold badges39 silver badges46 bronze badges

2 Comments

jonaz Over a year ago

I tried in most browsers. First one was firefox. Alert(1); in both a-tag and input-tag works fine. But i cannnot access form.saveFile from the input-onchange. Only from a-onclick

Senthil Kumar Over a year ago

try using document.getElementById('form_id'). since ids are unique, you wont get any problem when referring to elements in html page.

Collectives™ on Stack Overflow

javascript input field onchange causes "is not a function"

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related