MySQLi Not Changing Database Variables Properly

Question

I'm currently creating a ban form that bans users through the MySQLi database, however currently when I try to ban them, the 'active' changes to 0 as opposed to 2 and the banreason does not get updated... Here is the code

$qry = "UPDATE members SET active = '2' AND breason = '".$_POST['reason']."' WHERE login =  '".$_POST['login']."'";
$result = @mysqli_query($GLOBALS["___mysqli_ston"], $qry);
if($result) {
    header("location: banneduser?login=$login&reason=$reason");
    exit();
}else {
    die("Error:".((is_object($GLOBALS["___mysqli_ston"])) ? mysqli_error($GLOBALS["___mysqli_ston"]) : (($___mysqli_res = mysqli_connect_error()) ? $___mysqli_res : false)));
}

I am not receiving any error on the page.

Side question....where are you declaring $login and $reason, they are used as $_POST variables in the statement, and in your header they are just $login and $reason. — Kylie
– Kylie, Commented Jun 7, 2013 at 22:25
Try outputting your query before executing to see if it's correct: echo $qry; — showdev
– showdev, Commented Jun 7, 2013 at 22:26
@KyleK I initially used the variables, and I switched to $_Post wondering if it'd have any effect (I'm a noob when it comes to PHP) — Brad
– Brad, Commented Jun 7, 2013 at 22:31
@showdev I outputted the query and it displayed this UPDATE members SET active = '2' AND breason = 'omg' WHERE login = 'Test' Which is correct — Brad
– Brad, Commented Jun 7, 2013 at 22:37
also....just a quick thing to try....take the @ sign off of mysqli_query — Kylie
– Kylie, Commented Jun 7, 2013 at 22:37

Lepidosteus · Accepted Answer · 2013-06-08 00:12:59Z

1

Despite the fact that given the comments your code is insecure and you are ok with that, columns to be updated should not be separated by the AND operator in an UPDATE statement.

UPDATE [LOW_PRIORITY] [IGNORE] table_reference
    SET col_name1={expr1|DEFAULT} [, col_name2={expr2|DEFAULT}] ...
    [WHERE where_condition]
    ...

Replace your AND with a comma.

edited Jun 8, 2013 at 0:12

answered Jun 7, 2013 at 22:52

Lepidosteus

12.1k4 gold badges41 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

MySQLi Not Changing Database Variables Properly

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related