Alternate name for object instances stored in array, C#

Question

I have 2 object instances of same type. (To be precise this is Unity3D's AudioSource) I need to apply some action like initializing, destroying, etc to both, so I think storing them in an array would be a good idea so I can iterate.

AudioSource[] audioSources = new AudioSource[2];

With this I can foreach on the array and write initializing code and other common tasks only once.

But these two instances serves different purpose, say, the first is an AudioSource for BGM and the second is for SFX. This way the code will be more readable and I can still iterate over two instances by using the array.

So I think I should give an alternate names for each instance like bgmSource and sfxSource. I'd like to ask that is this the correct approach?

AudioSource bgmSource = audioSources[0];
AudioSource sfxSource = audioSources[1];

Nothing wrong with that. If you're not going to have a lot more of them though, you could also dispense with the array and just make/call subroutines like Initialize(AudioSource src). I'd consider two function calls at least as clean as a foreach on an array, and it removes the complexity of having multiple references to each object. — Blorgbeard
– Blorgbeard, Commented Jun 10, 2013 at 5:23

yelman · Accepted Answer · 2013-06-10 18:03:18Z

Another solution is using a Dictionary, its not very suitable for such small arrays but it can help you distinct between objects without using second variable to store reference to the one in the array.

For example:

    Dictionary< string, AudioSource > audioSources;

    audioSources = new Dictionary<string, AudioSource> 
    { 
        "BGM_SOURCE", new AudioSource(),
        "SFX_SOURCE", new AudioSource()
    };

Then you can also use enum for keeping track of dictionary keys instead of using string/constant values:

// Enum declaration
enum AudioSourceNames
{
    BGM_SOURCE,
    SFX_SOURCE
}


// Called before first update
public void Start()
{
    // Dictionary declaration
    Dictionary< int, AudioSource > audioSources;

    audioSources = new Dictionary< int, AudioSource > 
    { 
        ( int )BGM_SOURCE, new AudioSource(),
        ( int )SFX_SOURCE, new AudioSource()
    };


    // Accessing the dictionary
    audioSources[ ( int )AudioSourceNames.BGM_SOURCE ].Play();
}

BTW: You can use the enumarator technique with array, this way you won't have to remember each AudioSource index in the array

Micha · Accepted Answer · 2013-06-10 05:27:27Z

1

From my point of view your solution seem good.

initializing code and other common tasks only once

The code for these things is hopefully in AudioSource, isn't it?

answered Jun 10, 2013 at 5:27

Micha

5,1838 gold badges36 silver badges47 bronze badges

Comments

aiapatag · Accepted Answer · 2013-06-10 05:29:38Z

1

Well, it's legal. It's just a matter of preference/design. I would say that you could put them in a Dictionary of some sort. So you can properly label them through a key. That way you won't need to remember that [0] is bgmSource and [1] is sfxSource.

answered Jun 10, 2013 at 5:29

aiapatag

3,43823 silver badges24 bronze badges

Collectives™ on Stack Overflow

Alternate name for object instances stored in array, C#

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related