Javascript - Endless recursive function

Question

I'm currently working on a chrome extension that let the user click on a node to get its content. Getting the inner text is simple when using textContent, but getting the url of a picture in a clicked div...

I tried using this function to get the img node and thus being able to read its href/src:

function getimgtag(elem) //elem is the clicked div
{
    for(i=0;elem.getElementsByTagName('div')[i];i++)
    {
        getimgtag(elem.getElementsByTagName('div')[i]);
    }
    if(elem.getElementsByTagName('img')[0])
    {
        localStorage['fus_imgtag']=elem.getElementsByTagName('img')[0];
    }   

}

But it doesn't seems to have an end and I really don't understand why. Shouldn't it check all the div elements and place the last img found in localStorage['fus_imgtag']?

That's not the problem, but I would cache elem.getElementsByTagName('div') and elem.getElementsByTagName('img'). Calling it over and over again is a waste of resources. — Felix Kling
– Felix Kling, Commented Jun 12, 2013 at 8:17

elclanrs · Accepted Answer · 2013-06-12 08:35:33Z

2

You forgot to declare i as in var i. If you don't declare it, it becomes an implicit global variable which is always trouble particularly in your case where i should be scoped locally for every recursive call.

answered Jun 12, 2013 at 8:35

elclanrs

94.2k21 gold badges137 silver badges171 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Javascript - Endless recursive function

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related