out of scope - NSMutableArray error

Question

data = [[NSMutableArray arrayWithCapacity:numISF]init];
count = 0;
while (count <= numISF)
{   
    [data addObject:[[rouge_col_data alloc]init]];
    count++;
}

When I step through the while loop, each object in the data array is 'out of scope'

rouge col data 's implementation looks like this..

@implementation rouge_col_data
@synthesize pos;
@synthesize state;
-(id) init {
    self = [super init];    
    return self;
}
@end

Most tutorials I could find only use NSStrings for objects in these kinds of arrays.

-Thanks Alex E

EDIT

data = [[[NSMutableArray alloc] initWithCapacity:numISF]retain];
//data = [[NSMutableArray arrayWithCapacity:numISF] retain];
count = 0;
while (count < numISF)
{

    [data addObject:[[[rouge_col_data alloc]init]autorelease]];

    count++;

}

still the same error, even when switching the 'data = '.

Is there a better way to fix this?

DevEarley
– DevEarley

2009-11-12 18:39:06 +00:00
Commented Nov 12, 2009 at 18:39 — DevEarley
– DevEarley, Commented Nov 12, 2009 at 18:39

Carl Norum · Accepted Answer · 2009-11-10 17:45:32Z

3

You don't need to call init on the result of your arrayWithCapacity: call. arrayWithCapacity: already returns you an initialized (but autoreleased) object. Alternatively you could call [[NSMutableArray alloc] initWithCapacity:].
Your loop has an off by one error; you're starting at zero, so you'll add an extra object. Adding this extra object will succeed - it just doesn't seem like what you're trying to do.
You probably want to autorelease the objects you're adding to the array. The array will retain them on its own. If you do have some need to retain the objects themselves, that's fine, but it's pretty common to let the array do the retention for you.
You should retain the array itself, otherwise it will vanish at the end of the event loop.

edited Nov 10, 2009 at 17:45

answered Nov 10, 2009 at 17:38

Carl Norum

226k42 gold badges442 silver badges480 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

pgb · Accepted Answer · 2009-11-10 19:11:26Z

2

The only error I can spot in your code is your NSArray initialization.

Where you do:

data = [[NSMutableArray arrayWithCapacity:numISF] init];

you should be doing:

data = [NSMutableArray arrayWithCapacity:numISF];

This is because arrayWithCapacity is a factory method, and will return you an autoreleased instance. If you want to keep using the object after this method, you'll need to retain it, and your could will look like:

data = [[NSMutableArray arrayWithCapacity:numISF] retain];

edited Nov 10, 2009 at 19:11

answered Nov 10, 2009 at 17:38

pgb

25.1k12 gold badges86 silver badges115 bronze badges

1 Comment

Chuck Over a year ago

Whether you need to retain the array depends on whether you need it after the method finishes.

Collectives™ on Stack Overflow

out of scope - NSMutableArray error

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related