php mysql function for inserting records

Question

I have this piece of code that I am studying but don't see the purpose of a certain line.

public function insertRecords($table, $data){
    //setup some variables for fields and values
    $fields = "";
    $values = "";

    //populate them
    foreach($data as $f => $v){
        $fields .= "`$f`,";
        $values .= (is_numeric($v) && (intval($v) == $v)) ? $v . "," : "'$v',";
    }

    //remove our trailing ,
    $fields = substr($fields, 0, -1);
    //remove our trailing ,
    $values = substr($values, 0, -1);

    $insert = "INSERT INTO $table ({$fields}) values({$values})";
    //echo $insert
    $this->executeQuery($insert);
    return true;
}

I don't see the purpose of:

intval($v) == $v))

In the ternary operator. What I understand is, if the integer value of $v is the same as $v do blah. Of course the integer value of $v is going to be equal to $v. It's the current value in the current iteration. Is my understanding incorrect?

I already know that if intval() doesn't return a integer it defaults to a string in the ternary operator.

If $v is an integer, don't wrap it in quotes. If it's not (it's a string), wrap it in quotes. Depending on what you expect the value of $v to be, you may or may not need that line. But it seems that $v is a reasonably flexible value that could be a string or an integer. — showdev
– showdev, Commented Jun 13, 2013 at 23:51
It is merely ensuring that when $v is converted to an int, it still looks like $v. So, if $v is 3, intval(3)==3 is true. If $v is 3.1, intval(3.1)==3.1 is false. Obviously, any $v that is not a number will be false. I have a feeling that intval(null)==null will return true, but I haven't checked it. — kainaw
– kainaw, Commented Jun 13, 2013 at 23:52
Wouldn't it been wise to use the === strict comparison as a string "0" will be converted to an integer, for accuracy? — Robert
– Robert, Commented Jun 13, 2013 at 23:56
Almost like JavaScript's parseFloat and parseInt funcions don't you think? — Robert
– Robert, Commented Aug 6, 2013 at 3:11

Devon Bernard · Accepted Answer · 2013-06-13 23:55:56Z

1

You are correct in your assumption.

That line is merely a method of checking whether the variable $v is indeed an integer. Because if it is any other data-type the value would differ from that intval() operation.

answered Jun 13, 2013 at 23:55

Devon Bernard

2,3005 gold badges19 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2023-11-17 19:58:40Z

0

It is using intval() just because it's checking for the value entered to be an integer rather than a string wich would not be allowed in your query either for column datatype and for security purpose

intval — Get the integer value of a variable

edited Nov 17, 2023 at 19:58

CommunityBot

11 silver badge

answered Jun 13, 2013 at 23:56

Fabio

23.5k12 gold badges57 silver badges66 bronze badges

Comments

Mike · Accepted Answer · 2013-06-14 00:02:06Z

0

is_numeric($v) returns true if $v is a number (e.g. 234233) or numeric string (e.g. "234233"), whereas intval($v) == $v returns true if $v is an integer.

The first makes sure $v is a numeric in any way and seconds checks if $v is an integer.

I guess you could drop is_numeric($v)

answered Jun 14, 2013 at 0:02

Mike

1,1765 gold badges22 silver badges33 bronze badges

Collectives™ on Stack Overflow

php mysql function for inserting records

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related