JQuery: Appending Attribute Value to Each Element

Question

I am trying to append an additional url chunk to an existing attribute and simply update it.

$("img").each(function (i) {
    var originalSrc = $("img").attr('src');
    $("img").attr('src', 'http://www.domain-name.com/' + originalSrc);    
});

$("a").each(function (i) {
    var originalHref = $("a").attr('href');
    $("a").attr('href', 'http://www.domain-name.com/' + originalHref);    
});

It is counting all elements and appending a long string to the final attribute. I understand what's going on, but I'm not sure the correct way to go about this. This is obviously wrong.

Essentially, I'm scrubbing a remote page and I need to reset all relative connections to absolute.

I'm not certain I understand, what's the wrong part of this? — Bryan McLemore
– Bryan McLemore, Commented Nov 13, 2009 at 18:59
I didn't drink enough coffee this morning, that's what! :-) Thanks guys. Such a silly thing to have a mistake over. — ritsuke
– ritsuke, Commented Nov 13, 2009 at 19:04

spoulson · Accepted Answer · 2009-11-13 18:59:54Z

28

Try:

$("img").each(function () {
    var originalSrc = $(this).attr('src');
    $(this).attr('src', 'http://www.domain-name.com/' + originalSrc);    
});

answered Nov 13, 2009 at 18:59

spoulson

21.7k17 gold badges79 silver badges103 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

dave_427 · Accepted Answer · 2011-05-18 11:48:02Z

8

Even less work with (compare http://api.jquery.com/attr/) :

$("img").attr('src', function(i, val){
   return 'http://www.domain.com/' + val;
});

$("a").attr('href', function(i, val){
   return 'http://www.domain.com/' + val;
});

Greets

answered May 18, 2011 at 11:48

dave_427

811 silver badge1 bronze badge

Comments

Christian C. Salvadó · Accepted Answer · 2009-11-13 19:00:38Z

1

Since you are using the each method to loop over your elements, you should use the this keyword inside the callback function, to refer to the currently iterated element:

$("img").each(function (i) {
    var image = $(this), // 'this' is the image element being iterated
        originalSrc = image.attr('src');

    image.attr('src', 'http://www.domain-name.com/' + originalSrc);    
});

answered Nov 13, 2009 at 19:00

Christian C. Salvadó

831k185 gold badges929 silver badges845 bronze badges

Comments

JasonWyatt · Accepted Answer · 2009-11-13 19:01:32Z

0

Using your code structure:

$("img").each(function (i) {
    var $img = $(this);
    var originalSrc = $img.attr('src');   // use "this" in the $() function to get the current element...
    $img.attr('src', 'http://www.domain-name.com/' + originalSrc);    
});

$("a").each(function (i) {
    var $a = $(this);
    var originalHref = $a.attr('href');
    $a.attr('href', 'http://www.domain-name.com/' + originalHref);    
});

Make sure to use $(this) inside of jQuery's callback functions to retrieve the 'current' node in the node list.

answered Nov 13, 2009 at 19:01

JasonWyatt

5,3031 gold badge33 silver badges40 bronze badges

Comments

Linuxios · Accepted Answer · 2012-08-28 14:33:31Z

0

Inside each function use $(this) instead of $(a) and $(img).

edited Aug 28, 2012 at 14:33

Linuxios

35.9k13 gold badges96 silver badges118 bronze badges

answered Nov 13, 2009 at 19:00

Brandon Henry

3,7492 gold badges27 silver badges32 bronze badges

Collectives™ on Stack Overflow

JQuery: Appending Attribute Value to Each Element

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related