PHP/MySQL syntax error while trying to insert a couple values

Question

How can I fix this line in PHP/MySQL? The server returns the error

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''id', 'title', 'yes', 'no') VALUES (2,test, 0, 0)' at line 1

for the line

mysql_query("INSERT INTO things('id', 'title', 'yes', 'no') VALUES ($counter,$thing, 0, 0);", $con);

Kai Qing · Accepted Answer · 2013-07-03 00:52:51Z

2

"INSERT INTO things (`id`, `title`, `yes`, `no`) VALUES ($counter,$thing, 0, 0);"

Use ticks and not single quotes. Also, you are not quoting your string there. You should do proper sanitization.

You should switch to PDO or mysqli. mysql_ functions are deprecated.

answered Jul 3, 2013 at 0:52

Kai Qing

18.9k6 gold badges41 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Austin Berke Over a year ago

Thanks, that seems to fix that problem. But now it's saying Unknown column 'testtest' in 'field list' where testtest is $thing.

Kai Qing Over a year ago

right because you don't quote your string. ($counter,'$thing', 0, 0) would technically work but you really should do proper sanitizing through built in mysqli or PDO functions. Any tutorial on the two will show you how to do that

Lloyd Banks · Accepted Answer · 2013-07-03 00:54:23Z

0

You need quotes around $counter and $thing

mysql_query("INSERT INTO things('id', 'title', 'yes', 'no') 
VALUES ('$counter','$thing', 0, 0);", $con);

answered Jul 3, 2013 at 0:54

Lloyd Banks

37k58 gold badges172 silver badges264 bronze badges

Collectives™ on Stack Overflow

PHP/MySQL syntax error while trying to insert a couple values

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related