PHP Upload IF ISSET always says it is?

Question

OK, i have some kind of strange problem with my code. I'm trying to make uploading form with text along photos. Now, I need to check if the photo is uploaded or the text is inserted only.

The simplified code looks like this:

if (isset ($_FILES['image'])){
echo 'yes';


} else {    
echo 'no';      
}

the form looks like:

   <form action=""  method="post" enctype="multipart/form-data" class="contact-form">
   <form action=""  method="post" enctype="multipart/form-data" class="contact-form">


   <label for="title"><strong>Title</strong> (required)</label>
   <input type="text" name="title" value="" required>


   <label><span class="small"><strong>Add a photo</strong></span></label>
   <input type="file" name="image"/>


   <input type="submit" name"submit" value="Submit">    
   </form>

Now, basically, what I'm trying to make is a check if file is attached or not, because I need an alternate option for posting posts without photos, in the same form; but, the problem is that no mather if it is attached or not it always says YES.

Help, anyone.

Nop, same thing happens. I insert the title only, it says the file has been inserted. — uollaa
– uollaa, Commented Jul 5, 2013 at 15:19

Jimbo · Accepted Answer · 2015-09-10 09:15:35Z

20

To check if the file has been uploaded, how about:

if (!file_exists($_FILES['image']['tmp_name']) || !is_uploaded_file($_FILES['image']['tmp_name'])) 
{
    echo 'No upload';
}
else
{
    // Your file has been uploaded
}

is_uploaded_file() is the choice here, check the docs out for it.

$_FILES is an array of files, and each file in the first dimension of the array is automatically given a ['tmp_name'] key in the second dimension, with the value being it's temporary location.

Obviously you then need to use move_uploaded_file() on the temporary file.

edited Sep 10, 2015 at 9:15

answered Jul 5, 2013 at 15:25

Jimbo

26.7k16 gold badges93 silver badges135 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

uollaa Over a year ago

Thank you, I have solved it with this. P.s. uploading part isn't the problem (moving, entering db, everything works fine, this part was, when there is no file, just text) Thanks.

bystwn22 · Accepted Answer · 2013-07-05 15:35:24Z

4

You are checking only that $_FILES['image'] passed from your form.
But you are not checking that posted $_FILES['image'] is empty or its contains a valid file data
Read more here http://www.php.net/manual/en/features.file-upload.php

<?php
  if ( isset( $_FILES["image"] ) && !empty( $_FILES["image"]["name"] ) ) {
    if ( is_uploaded_file( $_FILES["image"]["tmp_name"] ) && $_FILES["image"]["error"] === 0 ) {
      // everything okay, do process
      echo 'yes';
      exit();
    }
  }
  echo 'no';
?>

answered Jul 5, 2013 at 15:35

bystwn22

1,7941 gold badge10 silver badges9 bronze badges

Comments

Stacy Davidson · Accepted Answer · 2018-04-02 15:24:03Z

2

The reason "isset" doesn't work is most likely because $_FILES is considered set even when it is set to "null". I found the empty() suggestion to be the cleanest. Although, unless you're using a large form with multiple files, I would remove the brackets entirely.

if (empty ($_FILES)){
 echo 'No file';
 } else {    
 echo 'File found';
 }

edited Apr 2, 2018 at 15:24

answered Apr 2, 2018 at 14:59

Stacy Davidson

212 bronze badges

Comments

Drew Lemmy · Accepted Answer · 2013-07-05 15:19:19Z

0

Use empty() instead.

if (!empty ($_FILES['image'])){
    echo 'yes';


} else {    
    echo 'no';      
}

answered Jul 5, 2013 at 15:19

Drew Lemmy

4371 gold badge4 silver badges13 bronze badges

1 Comment

uollaa Over a year ago

doesn't work, stil echoes 'yes' when the title is entered. I need 'no' :)

Ritesh Kumar · Accepted Answer · 2022-12-21 17:58:16Z

0

if(empty($_FILES['image']['name'])){echo 'not attached successfully';}
else{echo 'attached successfully';}

edited Dec 21, 2022 at 17:58

answered Dec 21, 2022 at 17:56

Ritesh Kumar

437 bronze badges

Collectives™ on Stack Overflow

PHP Upload IF ISSET always says it is?

5 Answers 5

1 Comment

Comments

Comments

1 Comment

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

1 Comment

Comments

Linked

Related