Stack overflow in nested loop in Visual Basic

Question

I made a constructor in my program but it kept giving me the stack overflow exception. I tried changing parameters but it did not help...

Public Sub New()
    InitializeComponent()

    For i As Integer = 0 To i = 12
        For j As Integer = 0 To i = 9
            atomcode(i, j) = (i * 10000 + j * 1000 + 99)
        Next j
    Next i

End Sub

Welcome to SO. Please read this on how to ask a question stackoverflow.com/questions/how-to-ask Show the call stack and the exception stack, how is atomcode() defined? We are not mind readers. — OldProgrammer
– OldProgrammer, Commented Jul 6, 2013 at 2:37
If I ask why the last parameter in the second "for" statement is an "i", am I just revealing that I don't understand the problem? — DJohnM
– DJohnM, Commented Jul 6, 2013 at 2:43
@OldProgrammer atomcode(i,j) is probably a two-dimensional array. VB uses parentheses instead of square brackets for array access. — Auri Rahimzadeh
– Auri Rahimzadeh, Commented Jul 6, 2013 at 2:54

Mark Hall · Accepted Answer · 2013-07-06 03:25:40Z

2

I am not sure if you tried typing your code in, or pasted your code. The format of your For statement is wrong and in the second statement you are using j and i both which if it worked would be incrementing j until i is = 9 which would cause your stackoverflow. something like this simple console program example should work. Also the only way your above code will compile is if you have Option Strict Off, do yourself a favor and place Option Strict On at the top of your Class, it will prevent implicit narrowing conversions and save you a lot of grief.

Option Strict On
Module Module1
    Dim atomcode(,) As Integer

    Sub Main()
        ReDim atomcode(12, 9)
        For i As Integer = 0 To 12
            For j As Integer = 0 To 9
                atomcode(i, j) = (i * 10000 + j * 1000 + 99)
            Next j
        Next i

    End Sub 

End Module

edited Jul 6, 2013 at 3:25

answered Jul 6, 2013 at 2:45

Mark Hall

54.7k9 gold badges101 silver badges116 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

PotatoManager Over a year ago

tht din help it still keeps me giving the overflow error I have initialized atomcode as a two dimensional array. is there an issue about it being a constructor?

Mark Hall Over a year ago

This code works in a Form constructor also., without any errors. You need to show more code, especially where you are creating your array. Usually StackOverflow errors are called by recursively calling a function. Nothing in the code you have shown is doing that.

PotatoManager Over a year ago

these are all my declarations code Public Class Constructor Dim atomcode(12, 9) As Integer Dim obj As Integer Dim active As Boolean = False Dim obg As New Constructor Dim i, j, k As Integer

PotatoManager Over a year ago

using option strict anywhere gives me a load of errors which I have never heard about..

Mark Hall Over a year ago

That is because you are letting VB do a lot of implicit narrowing conversions. Read the link on Option Strict that I put in the answer

|

Collectives™ on Stack Overflow

Stack overflow in nested loop in Visual Basic

1 Answer 1

9 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

9 Comments

Your Answer

Sign up or log in

Post as a guest

Related